Bug#236430: marked as done (gnome-cups-manager: menus suck)
Debian Bug Tracking System
owner@bugs.debian.org
Wed, 23 Jun 2004 05:48:13 -0700
Your message dated Wed, 23 Jun 2004 13:38:29 +0100
with message-id <1087994309.1977.81.camel@carados.180sw.com>
and subject line Fixed in 0.18
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 6 Mar 2004 08:53:20 +0000
>From mechanix@slider.rack66.net Sat Mar 06 00:53:20 2004
Return-path: <mechanix@slider.rack66.net>
Received: from slider.rack66.net [212.3.252.135] (postfix)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1AzXYe-0008Ck-00; Sat, 06 Mar 2004 00:53:20 -0800
Received: by slider.rack66.net (Postfix, from userid 1026)
id 997D0F567; Sat, 6 Mar 2004 09:53:19 +0100 (CET)
Date: Sat, 6 Mar 2004 09:53:19 +0100
From: Filip Van Raemdonck <mechanix@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: gnome-cups-manager: menus suck
Message-ID: <20040306085319.GB22100@debian>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="MfFXiAuoTsnnDAfZ"
Content-Disposition: inline
User-Agent: Mutt/1.3.28i
X-Reportbug-Version: 2.37
X-Marks-The-Spot: xxxxxxxxxx
X-GPG-Fingerprint: 1024D/8E950E00 CAC1 0932 B6B9 8768 40DB C6AA 1239 F709 8E95 0E00
X-Machine-info: Linux lucretia 2.6.2-rc1 i686
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_05
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0 tests=HAS_PACKAGE autolearn=no
version=2.60-bugs.debian.org_2004_03_05
X-Spam-Level:
--MfFXiAuoTsnnDAfZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Package: gnome-cups-manager
Tags: patch
Hi,
The menus in the printers overview for g-c-m currently suck; they don't
use stock items where they can and should; the "printer" menu has way too
meny separators; and arguably some menu items are in the wrong place
(actually, with the menu items that are currently there, one could argue
that all of them belong in the "printer" menu)
Attached patch addresses those issues.
Regards,
Filip
--
"If supporters' vociferousness and flamosity are valid measures of an OS'
enterprise readiness, Windows is obviously less enterprise-ready than
Linux (...) Steve Ballmer alone has shown as much anti-Linux vitriol as
all the pro-Linux, anti-Microsoft zealots (...) put together."
-- Robin Miller
--MfFXiAuoTsnnDAfZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=gcm-glade-diff
--- gnome-cups-manager-0.17/gnome-cups-manager/gnome-cups-manager.glade
+++ gnome-cups-manager-0.17-new/gnome-cups-manager/gnome-cups-manager.glade
@@ -1262,48 +1260,18 @@
<child>
<widget class="GtkImageMenuItem" id="new_printer_item">
<property name="visible">True</property>
- <property name="label" translatable="yes">_New Printer</property>
- <property name="use_underline">True</property>
+ <property name="label">gtk-new</property>
+ <property name="use_stock">True</property>
<signal name="activate" handler="on_new_printer1_activate" last_modification_time="Tue, 24 Jun 2003 14:04:13 GMT"/>
-
- <child internal-child="image">
- <widget class="GtkImage" id="image86">
- <property name="visible">True</property>
- <property name="stock">gtk-new</property>
- <property name="icon_size">1</property>
- <property name="xalign">0.5</property>
- <property name="yalign">0.5</property>
- <property name="xpad">0</property>
- <property name="ypad">0</property>
- </widget>
- </child>
- </widget>
- </child>
-
- <child>
- <widget class="GtkMenuItem" id="separator7">
- <property name="visible">True</property>
</widget>
</child>
<child>
<widget class="GtkImageMenuItem" id="open_item">
<property name="visible">True</property>
- <property name="label" translatable="yes">_Open</property>
- <property name="use_underline">True</property>
+ <property name="label">gtk-open</property>
+ <property name="use_stock">True</property>
<signal name="activate" handler="on_item1_activate" last_modification_time="Tue, 24 Jun 2003 14:04:13 GMT"/>
-
- <child internal-child="image">
- <widget class="GtkImage" id="image87">
- <property name="visible">True</property>
- <property name="stock">gtk-open</property>
- <property name="icon_size">1</property>
- <property name="xalign">0.5</property>
- <property name="yalign">0.5</property>
- <property name="xpad">0</property>
- <property name="ypad">0</property>
- </widget>
- </child>
</widget>
</child>
@@ -1314,50 +1282,11 @@
</child>
<child>
- <widget class="GtkImageMenuItem" id="properties_item">
- <property name="visible">True</property>
- <property name="label" translatable="yes">_Properties</property>
- <property name="use_underline">True</property>
- <signal name="activate" handler="on_properties_item_activate" last_modification_time="Wed, 25 Jun 2003 20:36:08 GMT"/>
-
- <child internal-child="image">
- <widget class="GtkImage" id="image88">
- <property name="visible">True</property>
- <property name="stock">gtk-properties</property>
- <property name="icon_size">1</property>
- <property name="xalign">0.5</property>
- <property name="yalign">0.5</property>
- <property name="xpad">0</property>
- <property name="ypad">0</property>
- </widget>
- </child>
- </widget>
- </child>
-
- <child>
- <widget class="GtkMenuItem" id="separator8">
- <property name="visible">True</property>
- </widget>
- </child>
-
- <child>
<widget class="GtkImageMenuItem" id="close_item">
<property name="visible">True</property>
- <property name="label" translatable="yes">_Close</property>
- <property name="use_underline">True</property>
+ <property name="label">gtk-quit</property>
+ <property name="use_stock">True</property>
<signal name="activate" handler="on_close_item_activate" last_modification_time="Tue, 24 Jun 2003 14:17:25 GMT"/>
-
- <child internal-child="image">
- <widget class="GtkImage" id="image89">
- <property name="visible">True</property>
- <property name="stock">gtk-close</property>
- <property name="icon_size">1</property>
- <property name="xalign">0.5</property>
- <property name="yalign">0.5</property>
- <property name="xpad">0</property>
- <property name="ypad">0</property>
- </widget>
- </child>
</widget>
</child>
</widget>
@@ -1416,6 +1343,12 @@
</child>
<child>
+ <widget class="GtkMenuItem" id="separator9">
+ <property name="visible">True</property>
+ </widget>
+ </child>
+
+ <child>
<widget class="GtkMenuItem" id="make_default_item">
<property name="visible">True</property>
<property name="label" translatable="yes">Make _Default</property>
@@ -1425,29 +1358,20 @@
</child>
<child>
- <widget class="GtkMenuItem" id="separator9">
+ <widget class="GtkImageMenuItem" id="delete_item">
<property name="visible">True</property>
+ <property name="label">gtk-remove</property>
+ <property name="use_stock">True</property>
+ <signal name="activate" handler="on_delete_item_activate" last_modification_time="Wed, 25 Jun 2003 20:36:08 GMT"/>
</widget>
</child>
<child>
- <widget class="GtkImageMenuItem" id="delete_item">
+ <widget class="GtkImageMenuItem" id="properties_item">
<property name="visible">True</property>
- <property name="label" translatable="yes">_Delete</property>
- <property name="use_underline">True</property>
- <signal name="activate" handler="on_delete_item_activate" last_modification_time="Wed, 25 Jun 2003 20:36:08 GMT"/>
-
- <child internal-child="image">
- <widget class="GtkImage" id="image92">
- <property name="visible">True</property>
- <property name="stock">gtk-delete</property>
- <property name="icon_size">1</property>
- <property name="xalign">0.5</property>
- <property name="yalign">0.5</property>
- <property name="xpad">0</property>
- <property name="ypad">0</property>
- </widget>
- </child>
+ <property name="label">gtk-properties</property>
+ <property name="use_stock">True</property>
+ <signal name="activate" handler="on_properties_item_activate" last_modification_time="Wed, 25 Jun 2003 20:36:08 GMT"/>
</widget>
</child>
</widget>
--MfFXiAuoTsnnDAfZ--
---------------------------------------
Received: (at 236430-done) by bugs.debian.org; 23 Jun 2004 12:38:31 +0000
>From ross@debian.org Wed Jun 23 05:38:31 2004
Return-path: <ross@debian.org>
Received: from smtp-out5.blueyonder.co.uk [195.188.213.8]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1Bd71L-00024D-00; Wed, 23 Jun 2004 05:38:31 -0700
Received: from lionel.180sw.com ([82.44.126.41]) by smtp-out5.blueyonder.co.uk with Microsoft SMTPSVC(5.0.2195.5600);
Wed, 23 Jun 2004 13:38:44 +0100
Received: from carados.180sw.com (unknown [192.168.0.2])
by lionel.180sw.com (Postfix) with ESMTP id 187AC15AAA8
for <236430-done@bugs.debian.org>; Wed, 23 Jun 2004 13:34:54 +0100 (BST)
Subject: Fixed in 0.18
From: Ross Burton <ross@debian.org>
To: 236430-done@bugs.debian.org
Content-Type: text/plain
Message-Id: <1087994309.1977.81.camel@carados.180sw.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6
Date: Wed, 23 Jun 2004 13:38:29 +0100
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 23 Jun 2004 12:38:44.0805 (UTC) FILETIME=[05B87750:01C4591F]
Delivered-To: 236430-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-1.0 required=4.0 tests=BAYES_20 autolearn=no
version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
I neglected to close this in 0.18-1.
Ross
--
Ross Burton mail: ross@burtonini.com
jabber: ross@burtonini.com
www: http://www.burtonini.com./
PGP Fingerprint: 1A21 F5B0 D8D0 CFE3 81D4 E25A 2D09 E447 D0B4 33DF