Bug#247198: acknowledged by developer (Bug#247198: fixed in pango1.0 1.2.5-5)

Flavio Stanchina Flavio Stanchina <flavio.stanchina@tin.it>, 247198@bugs.debian.org
Mon, 10 May 2004 11:33:36 +0200


This is a multi-part message in MIME format.
--------------020108000908010306070308
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

reopen 247198
thanks

Debian Bug Tracking System wrote:
>    + debian/pango.defoma:
>      - fixed to avoid the regex fails due to unquoted strings.
>        Thanks to Flavio Stanchina <flavio.stanchina@tin.it>
>        (closes: Bug#247198)

Akira,
version 1.2.5-5 doesn't actually fix the unquoted string that's giving 
me problems, but another similar case that I missed. I still get this 
warning:

   Setting up libpango1.0-common (1.2.5-5) ...
   Updating the modules list for Pango-1.2.0...done.
   Cleaning up font configuration of pango...
   Cleaning up category xfont..
   Updating font configuration of pango...
   Cleaning up category xfont..
   Updating category xfont..
   W: In pango::xfont('term'): Invalid [] range "9-1" in regex;
   marked by <-- HERE in m/[divide-zinc-iso8859-1 <-- HERE /
   at /var/lib/defoma/scripts/pango.defoma line 93.

Attached is a diff between my fix and your fix. As you'll see they are 
in different places. 8-/

-- 
Ciao, Flavio


--------------020108000908010306070308
Content-Type: text/x-patch;
 name="libpango-defoma-escape-v2.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="libpango-defoma-escape-v2.patch"

--- pango.defoma-patch	2004-05-03 21:18:07.000000000 +0200
+++ pango.defoma	2004-05-10 11:20:23.000000000 +0200
@@ -72,13 +72,14 @@
 
 	foreach my $i (@cache) {
 		my $font = $Id->{1}->[$i];
-		my $tmp;
+		my $enc;
 		$font =~ s/_/ /g;
 		$xe = get_xlfd_element ($font);
 		$xlfd = generate_xlfd ($xe);
 
 		if ($xe->{Weight} =~ /bold/ && ($xe->{Slant} eq 'o' || $xe->{Slant} eq 'i')) {
-			push (@inbn_xlfd, $xlfd) if (!grep (/$xe->{Foundry}-$xe->{Family}-$xe->{Encoding}/, @inbn_xlfd));
+			$enc = "$xe->{Foundry}-$xe->{Family}-$xe->{Encoding}";
+			push (@inbn_xlfd, $xlfd) if (!grep (/\Q$enc/, @inbn_xlfd));
 			next;
 		}
 		if ($xe->{Weight} !~ /bold/ && ($xe->{Slant} eq 'o' || $xe->{Slant} eq 'i')) {
@@ -89,8 +90,7 @@
 			push (@nnbn_xlfd, $xlfd) if (!grep (/$xe->{Foundry}-$xe->{Family}-$xe->{Encoding}/, @nnbn_xlfd));
 			next;
 		}
-		$tmp = "$xe->{Foundry}-$xe->{Family}-$xe->{Encoding}";
-		push (@nnnn_xlfd, $xlfd) if (!grep (/\Q$tmp/, @nnnn_xlfd));
+		push (@nnnn_xlfd, $xlfd) if (!grep (/$xe->{Foundry}-$xe->{Family}-$xe->{Encoding}/, @nnnn_xlfd));
 	}
 	return \(@nnnn_xlfd, @innn_xlfd, @nnbn_xlfd, @inbn_xlfd);
 }

--------------020108000908010306070308--