Bug#248827: marked as done (balsa: incorrect fallback encoding)

Debian Bug Tracking System owner@bugs.debian.org
Sun, 21 Nov 2004 19:33:10 -0800


Your message dated Sun, 21 Nov 2004 22:17:04 -0500
with message-id <E1CW4hM-0003e4-00@newraff.debian.org>
and subject line Bug#248827: fixed in balsa 2.2.6-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 13 May 2004 09:53:56 +0000
>From dam@creditreform.bg Thu May 13 02:53:56 2004
Return-path: <dam@creditreform.bg>
Received: from mail.creditreform.bg [212.36.1.3] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BOCuZ-0000uC-00; Thu, 13 May 2004 02:53:55 -0700
Received: from amavis  <dam@creditreform.bg>
	by mail2.creditreform.bg with no-scan (Exim 3.35 #1 (Debian))
	id 1BOCuX-0007A1-00
	for <submit@bugs.debian.org>; Thu, 13 May 2004 12:53:53 +0300
Received: from pc1.creditreform.bg ([192.168.110.32])
	cipher TLSv1:RC4-SHA:128 <dam@creditreform.bg>
	by mail2.creditreform.bg with esmtp (Exim 3.35 #1 (Debian))
	id 1BOCuV-00079v-00; Thu, 13 May 2004 12:53:51 +0300
Received: from dam by pc1.creditreform.bg with local (Exim 4.33)
	id 1BOCuU-0006kI-AR; Thu, 13 May 2004 12:53:50 +0300
Content-Type: multipart/mixed; boundary="===============0470185755=="
MIME-Version: 1.0
From: "Damyan Ivanov \(at work\)" <divanov@creditreform.bg>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: balsa: incorrect fallback encoding
X-Mailer: reportbug 2.58
Date: Thu, 13 May 2004 12:53:50 +0300
Message-Id: <E1BOCuU-0006kI-AR@pc1.creditreform.bg>
Sender: Damyan Ivanov <dam@creditreform.bg>
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: dam@pc1
X-SA-Exim-Scanned: No (on pc1.creditreform.bg); SAEximRunCond expanded to false
X-Scanned-By: AMaViS-ng at mail.creditreform.bg
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-7.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 
X-CrossAssassin-Score: 1

This is a multi-part MIME message sent by reportbug.

--===============0470185755==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: balsa
Version: 2.0.17-2
Severity: minor
Tags: patch

Hi,

I can't make balsa to properly detect cp1251 in messages without
specified encoding in headers.


What I did:

Open Settings->Preferences.
Choose Display, choose Message

In 'National (8-bit) characters in broken messages...' choose 'display
using codeset'.

Now look at the available codesets. There is no cp1251
(Windows-1251/Wincows-Cyrillic). There is 'cyrillic (iso/windows)'. I
selected it, but any cp1251-encoded  message without proper encoding in
headers is displayed as iso-8859-5 (as seen in the warning about
conversion message).


I toke a look in the source and the problem appears to be in
libbalsa/misc.c:1118. In function libbalsa_get_codeset_name there is
assumption that windows' codesets contain characters in range 0x80-0x9f.
This is not true for windows-1251, which contains cyrilics in the range
0xC0-0xFF. Looking at 1250-1257 codesets, they all mainly use the range
0xC0-0xFF for letters...

So the destinction upon using 0x80-0x9f is wrong.

The only way I see for fixing this is to display all available encodings
in fallback codeset menu, and avoid the guesswork.
      
Patch attached. Windows' codesets just added in the end of the list,
some reordering and cleanup may be appropriate. I've avoided cleaning up
to keep the patch small.


Thanks,
dam


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.5
Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8

Versions of packages balsa depends on:
ii  gsfonts                   8.14-3         Fonts for the Ghostscript interpre
ii  libart-2.0-2              2.3.16-5       Library of functions for 2D graphi
ii  libaspell15               0.50.5-2       The GNU Aspell spell-checker runti
ii  libatk1.0-0               1.6.0-2        The ATK accessibility toolkit
ii  libaudiofile0             0.2.6-3        Open-source version of SGI's audio
ii  libbonobo2-0              2.6.0-1        Bonobo CORBA interfaces library
ii  libbonoboui2-0            2.6.0-1        The Bonobo UI library
ii  libc6                     2.3.2.ds1-12   GNU C Library: Shared libraries an
ii  libesd-alsa0 [libesd0]    0.2.29-1       Enlightened Sound Daemon (ALSA) - 
ii  libesmtp5                 1.0.3-1        LibESMTP SMTP client library
ii  libfontconfig1            2.2.2-2        generic font configuration library
ii  libfreetype6              2.1.7-2        FreeType 2 font engine, shared lib
ii  libgail-common            1.4.1-1        GNOME Accessibility Implementation
ii  libgail17                 1.4.1-1        GNOME Accessibility Implementation
ii  libgal2.0-6               1.99.11-1      G App Libs (run time library)
ii  libgconf2-4               2.6.1-1        GNOME configuration database syste
ii  libgcrypt1                1.1.12-4       LGPL Crypto library - runtime libr
ii  libglade2-0               1:2.3.6-4      Library to load .glade files at ru
ii  libglib2.0-0              2.4.1-1        The GLib library of C routines
ii  libgnome2-0               2.6.0-4        The GNOME 2 library - runtime file
ii  libgnomecanvas2-0         2.6.0-3        A powerful object-oriented display
ii  libgnomeprint2.2-0        2.6.0-1        The GNOME 2.2 print architecture -
ii  libgnomeprintui2.2-0      2.4.2-2        The GNOME 2.2 print architecture U
ii  libgnomeui-0              2.6.0-8        The GNOME 2 libraries (User Interf
ii  libgnomevfs2-0            2.6.0-4        The GNOME virtual file-system libr
ii  libgnomevfs2-common       2.6.0-4        The GNOME virtual file-system libr
ii  libgnutls7                0.8.12-5       GNU TLS library - runtime library
ii  libgpg-error0             0.7-1          library for common error values an
ii  libgpgme11                0.4.6-1        GPGME - GnuPG Made Easy
ii  libgtk2.0-0               2.4.1-1        The GTK+ graphical user interface 
ii  libgtkhtml3.0-4           3.0.10-1       HTML rendering/editing library - r
ii  libice6                   4.3.0.dfsg.1-1 Inter-Client Exchange library
ii  libjpeg62                 6b-9           The Independent JPEG Group's JPEG 
ii  libldap2                  2.1.29-2       OpenLDAP libraries
ii  libltdl3                  1.5.6-1        A system independent dlopen wrappe
ii  liborbit2                 1:2.10.0-0.1   libraries for ORBit2 - a CORBA ORB
ii  libpango1.0-0             1.4.0-1        Layout and rendering of internatio
ii  libpcre3                  4.5-1.1        Perl 5 Compatible Regular Expressi
ii  libpopt0                  1.7-4          lib for parsing cmdline parameters
ii  libsm6                    4.3.0.dfsg.1-1 X Window System Session Management
ii  libssl0.9.7               0.9.7d-2       SSL shared libraries
ii  libtasn1-0                0.1.2-2        Manage ASN.1 structures (runtime)
ii  libx11-6                  4.3.0.dfsg.1-1 X Window System protocol client li
ii  libxml2                   2.6.9-2        GNOME XML library
ii  scrollkeeper              0.3.14-8       A free electronic cataloging syste
ii  xlibs                     4.3.0.dfsg.1-1 X Window System client libraries m
ii  zlib1g                    1:1.2.1-5      compression library - runtime

-- no debconf information

--===============0470185755==
Content-Type: application/octet-stream
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="balsa-2.0.17+all-codesets.patch.gz"

H4sIALBDo0AAA41YW2/aShB+Lr9ixEMFwQ6+hkvbo5AUNZxwkgqCoqOjChl7CS5kjXwRqar+97Pr
GzuLgeQBe3e+mR3PfDuzm0e6+QU+hYWziRzVuNQu9U4/G11GW+LWPH+5BDUENUGY9sZfpOP2qx+5
ly4s/TfiqacgNVVVT9r4YGiaqeqGampg6H1d62vmpVb8QUtj8lqr1XrHWtyUpWq2qpug632r17d7
yJTJTF1fg6rrmq1cQSt96hZcX9cg+3uYjccK1Hc+9YJdxNyyO3UlnxV+MXz/C38+1aDWimIn9l14
cVdOCBfOZjN3A49EJI7+G49ubgbj6WD+MPtnfvv4dTgdPk1/wJdaKzX4G+p+FKjdrt1TdbbyfmSg
kYlGFhrZbJSbA2H6CoE6aNRFox4a6VpdqTCnY/d07JGOXdK5T/V14KvdULSWziRcRhJX/bkt3tZh
HWfBkMbIJ2Fel3BX0tiUxvYRO1ZdZgFPbasG7QuW+wuYkDgJKcQrAtR5JRAswYE8yeC4bhB6Pn2B
OIDbbPISRkuI32LwI6BBnHPGj1JrbC5yHUqJB8sgBE6bCBYk3hFCQXvrauBQj730lqmZKHFXfDnO
Lqa6DBLqKcwXZi1jt25m7DZ0pZuSOyekG9AoLmhZg2L7zF9IXDB0zj+ngYDMawXG/uKGY/PPKT6r
WYPfWQDDLCKI7DnoRxo5AH8JDR6Cjx+BhfYQ1sy21W7lbwg0+LpNZj3PDle+aCQ08l94nDLXmtzc
X1+yGDGz1YDPaeia76xqq/OVZnWuqq2yqqZ1VKPLq5rV6RvGQSl6V1Vboapm9HWrb5uVVc2yFcOC
FnuYRpr1+NeWeGQJhCavMJczKI154TqC/F1TeQaeh9On+XA2efw+VPKksO0A+00OjLvinoWLdqY5
HJzWNCRNjWu23rdmgTy/BkOms9PH2dOdBBWRZol8eJycRFrlF97+OxmNx6PbcmkJaUtfqJeag8ng
ButhzStJ86rU/DYZDu+xItLsSJpmqXk3vJkMn4+v2ZU07VLzaTa5H03vlGOaPUnTKvNzPkIF8nxE
CuT5CBTI819cIM9/ocCOr6f81LUS+nQ3GEl+YuieD+x08HTSqimFeP+R71AtHLodnoFaJVTYgulD
kaF2CZ3MptPR4EGOXdb3S9TsfjIYPQwrUUmJ+nvwXbKUorJzQom6f5wMB9WodVhVRebPo8wqQ8m1
Sq4jR7DaAadL4AFWl1gtImWsxGsMlbCmxOxTdm2Z2wiMsZZEplN2O2UWKg+1tewwfKzpRqHb3oZk
qb461HkhYfVt4hB12HoPMfmdQlcNAzSd9cu+Zr/3TlFtTWjArJ1r1dcK0zbSDsyfeQtOQ4DPXcVB
a+MsyObofaBoug/zRn1HmDZJwmBLHMqOUKHj+bEfUGfTrDeVPY44Ag5JoiCJV9UiGoTHRO6v0N9s
2LmxwTZ7O888XtIJnYXvoqmXkJA1mlmRRUh2aIqdFdd+tJI98SRb8crx0QRLVSxhXHIwJQWMv2G3
wySKfC5iRQdLknXo0GrRT2frUJY6NLkOwjRs2aapWHxfJ1NrJQwlS4AZGIYzJ+BMjMNpFHAWxqGc
5p0XI7KUCvIrLE/zK4g7WJwlW5B3sTzPvADoHXyJh9bXNckCI4UolgKbUUQESKHKCCMCpBhV0Kct
tDsMFqnEuhwWIjax7oalBaH4EryrYWnGrEy2Dk96KDaykywTu9gxXojdq5oZYs+q5IbYqKrZIban
I/wQu1J1hsVexBBFtWVdil+XabBL7+f+65btDYfG7BacLJd93rXSaq0ZPaXDqrVmdtiz+B+QfPmh
n7L5b/H62ffYTRkuXtk1iVXol3g9569zSnaNZg7LKgO/xTcowwgnj09A4fOX7MTC3lutvGYcxVa3
1VwVPjieN49WwS71oTFv4L5CfzQVoApwYeFbfkXnU2zmT+1/xRWgXwcUAAA=
--===============0470185755==--

---------------------------------------
Received: (at 248827-close) by bugs.debian.org; 22 Nov 2004 03:23:29 +0000
>From katie@ftp-master.debian.org Sun Nov 21 19:23:28 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CW4nY-0000hL-00; Sun, 21 Nov 2004 19:23:28 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1CW4hM-0003e4-00; Sun, 21 Nov 2004 22:17:04 -0500
From: Andrew Lau <netsnipe@users.sourceforge.net>
To: 248827-close@bugs.debian.org
X-Katie: $Revision: 1.51 $
Subject: Bug#248827: fixed in balsa 2.2.6-1
Message-Id: <E1CW4hM-0003e4-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Sun, 21 Nov 2004 22:17:04 -0500
Delivered-To: 248827-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Source: balsa
Source-Version: 2.2.6-1

We believe that the bug you reported is fixed in the latest version of
balsa, which is due to be installed in the Debian FTP archive:

balsa_2.2.6-1.diff.gz
  to pool/main/b/balsa/balsa_2.2.6-1.diff.gz
balsa_2.2.6-1.dsc
  to pool/main/b/balsa/balsa_2.2.6-1.dsc
balsa_2.2.6-1_i386.deb
  to pool/main/b/balsa/balsa_2.2.6-1_i386.deb
balsa_2.2.6.orig.tar.gz
  to pool/main/b/balsa/balsa_2.2.6.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 248827@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andrew Lau <netsnipe@users.sourceforge.net> (supplier of updated balsa package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 21 Nov 2004 15:36:42 +1100
Source: balsa
Binary: balsa
Architecture: source i386
Version: 2.2.6-1
Distribution: unstable
Urgency: low
Maintainer: Andrew Lau <netsnipe@users.sourceforge.net>
Changed-By: Andrew Lau <netsnipe@users.sourceforge.net>
Description: 
 balsa      - An e-mail client for GNOME
Closes: 248827 278617
Changes: 
 balsa (2.2.6-1) unstable; urgency=low
 .
   * New upstream release.
     - Mailbox counters fixed
       (closes: #278617)
     - Windows-125x codesets included in list of fallback encodings.
       (closes: #248827)
   * S/MIME support disabled due to requirement of alpha version (1.9) of GnuPG.
Files: 
 f0f1a7ded9841f4de39150bc42865078 1629 gnome optional balsa_2.2.6-1.dsc
 e117bd65d78f733df6d78d8dccfa5e4d 4418438 gnome optional balsa_2.2.6.orig.tar.gz
 798e603d7353150061f663daf77adb8c 7161 gnome optional balsa_2.2.6-1.diff.gz
 ec1bc1e312a8de0015af61c30bf4522f 2169858 gnome optional balsa_2.2.6-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBoVhRt1anjIgqbEsRAp0fAJ9hhU3XC8PTeudQTzL14QvRg0+VGgCg30SD
Tld913qTn5m9IEy1iya22oo=
=FW6j
-----END PGP SIGNATURE-----