Bug#270245: rhythmbox: doesn't interact well with firefox

[Alexandre]

--s5/bjXLgkIwAv6Hi
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 12, 2004 at 05:43:56PM +0200, Lo=EFc Minier wrote:
> reassign 225088 rhythmbox
> thanks
>=20
>      Hi,
>=20
>  I'm sorry, the re-reading of 225088 proved it was rhythmbox fault: HTTP
>  URLs should not contain the "|" character.  Quoting the BNC of RFC
>  1738:
>     httpurl        =3D "http://" hostport [ "/" hpath [ "?" search ]]
>     hpath          =3D hsegment *[ "/" hsegment ]
>     hsegment       =3D *[ uchar | ";" | ":" | "@" | "&" | "=3D" ]
>     search         =3D *[ uchar | ";" | ":" | "@" | "&" | "=3D" ]
>=20
>  I'll see how this can be fixed in rhythmbox.  Sorry.

The following patch seems to work for me:

--- rhythmbox-0.8.7.orig/widgets/rb-header.c
+++ rhythmbox-0.8.7/widgets/rb-header.c
@@ -525,7 +525,7 @@

                        s =3D tmp =3D g_strdup (album);
                        while ((tmp =3D strstr (tmp, " ")) !=3D NULL)
-                               *tmp =3D '|';
+                               *tmp =3D '+';
                        tmp =3D album_info_url (s);
                        g_free (s);

@@ -544,7 +544,7 @@
                        s =3D tmp =3D g_strdup (artist);
                        while ((tmp =3D strstr (tmp, " ")) !=3D NULL)
                        {
-                               *tmp =3D '|';
+                               *tmp =3D '+';
                        }
                        tmp =3D artist_info_url (s);
                        g_free (s);

I really wonder where the '|' came from in the first place. Maybe Colin
Walters could answer that ? He's mentionned in NEWS for working on this.=20

--=20
Alexandre Fayolle                              LOGILAB, Paris (France).
http://www.logilab.com   http://www.logilab.fr  http://www.logilab.org

--s5/bjXLgkIwAv6Hi
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBbCLqLl/b4N9npV4RAuBTAJ9GK93lfBBqfEuxiFOAYv8k2c5heQCdG/Rp
rW0+teIfip6d0tq8/6gH3xs=
=7K+w
-----END PGP SIGNATURE-----

--s5/bjXLgkIwAv6Hi--