Bug#303969: marked as done (pkg.m4 macro expansion confusion)

Debian Bug Tracking System owner@bugs.debian.org
Tue, 12 Apr 2005 05:18:11 -0700


Your message dated Tue, 12 Apr 2005 07:48:17 -0400
with message-id <E1DLJsP-0001iV-00@newraff.debian.org>
and subject line Bug#303969: fixed in pkgconfig 0.17-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 10 Apr 2005 01:26:28 +0000
>From manish@gimp.org Sat Apr 09 18:26:28 2005
Return-path: <manish@gimp.org>
Received: from shill.xcf.berkeley.edu (wilber.gimp.org) [128.32.112.247] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DKRDY-0008JG-00; Sat, 09 Apr 2005 18:26:28 -0700
Received: from manish by wilber.gimp.org with local (Exim 3.35 #1 (Debian))
	id 1DKRDX-0003Au-00
	for <submit@bugs.debian.org>; Sat, 09 Apr 2005 18:26:27 -0700
Date: Sat, 9 Apr 2005 18:26:27 -0700
From: Manish Singh <yosh@gimp.org>
To: submit@bugs.debian.org
Subject: pkg.m4 macro expansion confusion
Message-ID: <20050410012627.GA11079@gimp.org>
Reply-To: Manish Singh <yosh@gimp.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="uAKRQypu60I7Lcqm"
Content-Disposition: inline
User-Agent: Mutt/1.3.28i
X-Unexpected-Header: Hah! Nobody expects the unexpected header!
Sender: Manish Singh <manish@gimp.org>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 


--uAKRQypu60I7Lcqm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Package: pkg-config
Version: 0.16.0-1
Severity: important

GTK+ does the following in its configure.in:

PKG_CHECK_MODULES(BASE_DEPENDENCIES,
  [glib-2.0 >= glib_required_version dnl
   atk >= atk_required_version dnl
   pango >= pango_required_version])

This worked perfectly fine with the older pkg-config pkg.m4. With the
new one, one gets:

configure.in:131: error: possibly undefined macro: dnl

and configure bails.

Something is going haywire with autoconf and m4 expansion. The attached
patch fixes it.

-Yosh

--uAKRQypu60I7Lcqm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="pkgm4.patch"

--- /usr/share/aclocal/pkg.m4	2005-03-30 08:01:48.000000000 -0800
+++ pkg.m4	2005-04-09 18:17:38.000000000 -0700
@@ -67,11 +67,12 @@
 AC_ARG_VAR([$1][_CFLAGS], [C compiler flags for $1, overriding pkg-config])dnl
 AC_ARG_VAR([$1][_LIBS], [linker flags for $1, overriding pkg-config])dnl
 
+pkg_check_modules="$2"
 pkg_failed=no
 AC_CACHE_CHECK([for $1][_CFLAGS], [pkg_cv_][$1][_CFLAGS],
-	[_PKG_CONFIG([$1][_CFLAGS], [cflags], [[$2]])])
+	[_PKG_CONFIG([$1][_CFLAGS], [cflags], [$pkg_check_modules])])
 AC_CACHE_CHECK([for $1][_LIBS], [pkg_cv_][$1][_LIBS],
-	[_PKG_CONFIG([$1][_LIBS], [libs], [[$2]])])
+	[_PKG_CONFIG([$1][_LIBS], [libs], [$pkg_check_modules])])
 
 if test $pkg_failed = yes; then
 	$1[]_PKG_ERRORS=`$PKG_CONFIG --errors-to-stdout --print-errors "$2"`
@@ -79,7 +80,7 @@
 	echo "$$1[]_PKG_ERRORS" 1>&AS_MESSAGE_LOG_FD
 
 	ifelse([$4], , [AC_MSG_ERROR(dnl
-[[Package requirements ($2) were not met.
+[[Package requirements ($pkg_check_modules) were not met.
 Consider adjusting the PKG_CONFIG_PATH environment variable if you
 installed software in a non-standard prefix.
 

--uAKRQypu60I7Lcqm--

---------------------------------------
Received: (at 303969-close) by bugs.debian.org; 12 Apr 2005 12:08:02 +0000
>From katie@ftp-master.debian.org Tue Apr 12 05:08:02 2005
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DLKBW-0006Tj-00; Tue, 12 Apr 2005 05:08:02 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1DLJsP-0001iV-00; Tue, 12 Apr 2005 07:48:17 -0400
From: Tollef Fog Heen <tfheen@debian.org>
To: 303969-close@bugs.debian.org
X-Katie: $Revision: 1.55 $
Subject: Bug#303969: fixed in pkgconfig 0.17-1
Message-Id: <E1DLJsP-0001iV-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Tue, 12 Apr 2005 07:48:17 -0400
Delivered-To: 303969-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Source: pkgconfig
Source-Version: 0.17-1

We believe that the bug you reported is fixed in the latest version of
pkgconfig, which is due to be installed in the Debian FTP archive:

pkg-config_0.17-1_i386.deb
  to pool/main/p/pkgconfig/pkg-config_0.17-1_i386.deb
pkgconfig_0.17-1.diff.gz
  to pool/main/p/pkgconfig/pkgconfig_0.17-1.diff.gz
pkgconfig_0.17-1.dsc
  to pool/main/p/pkgconfig/pkgconfig_0.17-1.dsc
pkgconfig_0.17.orig.tar.gz
  to pool/main/p/pkgconfig/pkgconfig_0.17.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 303969@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Tollef Fog Heen <tfheen@debian.org> (supplier of updated pkgconfig package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 12 Apr 2005 13:21:08 +0200
Source: pkgconfig
Binary: pkg-config
Architecture: source i386
Version: 0.17-1
Distribution: unstable
Urgency: low
Maintainer: Tollef Fog Heen <tfheen@debian.org>
Changed-By: Tollef Fog Heen <tfheen@debian.org>
Description: 
 pkg-config - manage compile and link flags for libraries
Closes: 303969
Changes: 
 pkgconfig (0.17-1) unstable; urgency=low
 .
   * New upstream release
     - evaluate second argument again (closes: #303969)
   * pass --disable-indirect-deps to configure for now.  This'll change
     post-sarge, but we don't want to introduce breakage now.
   * lowercase first letter in description to shut up lintian
Files: 
 0df5bba527b1057c5235c70731484671 583 devel optional pkgconfig_0.17-1.dsc
 a7d9844b3d89af68388f9fa996634322 964339 devel optional pkgconfig_0.17.orig.tar.gz
 91fbd34b6d67ec0204b9b1bdfa78c053 3792 devel optional pkgconfig_0.17-1.diff.gz
 6efb255447fd26b7d29b810ce43357d3 50594 devel optional pkg-config_0.17-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFCW7ObQSseMYF6mWoRApk5AKCHDqR711wKp4pHlfm3HQqY+1UlHQCg8X27
7ykhrPe8nOkdkNEEPCboCbI=
=WIo8
-----END PGP SIGNATURE-----