Bug#342067: gnome-games: gnobots2 image theme accidentally includes extra graphics

[Daniel Kahn Gillmor]

Package: gnome-games
Version: 1:2.10.1-5.1
Severity: minor
Tags: patch


in gnobots2 on my mixed etch/sid system, i'm offered two non-sensical
graphics themes "teleport" and "rteleport".  It looks like this is
because a function in graphics.c is mis-filtering
/usr/share/pixmaps/gnobots, and doesn't properly ignore the pngs used
for the button images.

The attached patch (untested) should fix the issue, though it doesn't
do so in any principled fashion.

Thanks for maintaining these addictive time-wasters!

	--dkg

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (700, 'testing'), (700, 'stable'), (600, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12-1-686
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)

Versions of packages gnome-games depends on:
ii  gnome-games-data          1:2.10.1-5.1   data files for the GNOME games
ii  guile-1.6-libs            1.6.7-1        Main Guile libraries
ii  libart-2.0-2              2.3.17-1       Library of functions for 2D graphi
ii  libatk1.0-0               1.10.3-1       The ATK accessibility toolkit
ii  libaudiofile0             0.2.6-6        Open-source version of SGI's audio
ii  libbonobo2-0              2.10.1-1       Bonobo CORBA interfaces library
ii  libbonoboui2-0            2.10.1-1       The Bonobo UI library
ii  libc6                     2.3.5-8        GNU C Library: Shared libraries an
ii  libesd0                   0.2.36-1       Enlightened Sound Daemon - Shared 
ii  libgcc1                   1:4.0.2-2      GCC support library
ii  libgconf2-4               2.10.1-6       GNOME configuration database syste
ii  libglade2-0               1:2.5.1-2      library to load .glade files at ru
ii  libglib2.0-0              2.8.3-1        The GLib library of C routines
ii  libgnome2-0               2.10.1-1       The GNOME 2 library - runtime file
ii  libgnomecanvas2-0         2.10.2-2       A powerful object-oriented display
ii  libgnomeui-0              2.10.1-1       The GNOME 2 libraries (User Interf
ii  libgnomevfs2-0            2.10.1-5       The GNOME virtual file-system libr
ii  libgtk2.0-0               2.6.10-1       The GTK+ graphical user interface 
ii  libguile-ltdl-1           1.6.7-1        Guile's patched version of libtool
ii  libice6                   6.8.2.dfsg.1-7 Inter-Client Exchange library
ii  liborbit2                 1:2.12.4-1     libraries for ORBit2 - a CORBA ORB
ii  libpango1.0-0             1.8.2-3        Layout and rendering of internatio
ii  libpopt0                  1.7-5          lib for parsing cmdline parameters
ii  libqthreads-12            1.6.7-1        QuickThreads library for Guile
ii  librsvg2-2                2.9.5-4        SAX-based renderer library for SVG
ii  libsm6                    6.8.2.dfsg.1-7 X Window System Session Management
ii  libstdc++6                4.0.2-2        The GNU Standard C++ Library v3
ii  libxml2                   2.6.22-2       GNOME XML library
ii  xlibs                     6.8.2.dfsg.1-7 X Window System client libraries m
ii  zlib1g                    1:1.2.3-8      compression library - runtime

Versions of packages gnome-games recommends:
pn  gnome-games-extra-data        <none>     (no description available)
ii  python                        2.3.5-3    An interactive high-level object-o

-- no debconf information
-------------- next part --------------
diff -ru gnome-games-2.10.2.orig/gnobots2/graphics.c gnome-games-2.10.2/gnobots2/graphics.c
--- gnome-games-2.10.2.orig/gnobots2/graphics.c	2005-02-02 02:07:54.000000000 -0500
+++ gnome-games-2.10.2/gnobots2/graphics.c	2005-12-04 22:09:27.000000000 -0500
@@ -205,6 +205,12 @@
     if (! strcmp (dent, "splat.png")) {
       continue;
     }
+    if (! strcmp (dent, "teleport.png")) {
+      continue;
+    }
+    if (! strcmp (dent, "rteleport.png")) {
+      continue;
+    }
     if (! strcmp (dent, "gnome-gnobots2.png")) {
       continue;
     }