Bug#297191: gnome-media: cddb-slave2 doesn't handle multiple
exact CDDB matches
Lorenzo Colitti
Lorenzo Colitti <lorenzo@colitti.com>, 297191@bugs.debian.org
Sun, 27 Feb 2005 21:54:14 +0100
This is a multi-part MIME message sent by reportbug.
--===============0433565357==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Package: gnome-media
Version: 2.8.0-0.2
Severity: normal
Tags: patch
[Also submitted to GNOME as http://bugzilla.gnome.org/show_bug.cgi?id=168691 ]
If I use gnome-cd to play a CD which has multiple exact matches in the CDDB
database, gnome-cd does not show the name of the CD. This is because
cddb-slave2 does not handle the "multiple exact matches" response (code 210 in
the CDDB protocol). It handles the "multiple inexact matches" response (code
211) fine and correctly prompts the user to choose.
Examples of discs affected are:
Selling England by the Pound (Genesis)
Fugazi(Marillion)
etc.
The attached patch fixes the problem for me.
-- System Information:
Debian Release: 3.1
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.11-rc4-swsusp-2.1.7
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
Versions of packages gnome-media depends on:
ii gstreamer0.8-alsa [g 0.8.7-3 ALSA plugin for GStreamer
ii gstreamer0.8-artsd [ 0.8.7-3 aRtsd plugin for GStreamer
ii gstreamer0.8-esd [gs 0.8.7-3 Enlightened Sound Daemon plugin fo
ii gstreamer0.8-jack [g 0.8.7-3 JACK plugin for GStreamer
ii gstreamer0.8-misc 0.8.7-3 Collection of various GStreamer pl
ii gstreamer0.8-oss [gs 0.8.7-3 OSS plugin for GStreamer
ii libart-2.0-2 2.3.17-1 Library of functions for 2D graphi
ii libatk1.0-0 1.8.0-4 The ATK accessibility toolkit
ii libaudiofile0 0.2.6-5 Open-source version of SGI's audio
ii libbonobo2-0 2.8.1-2 Bonobo CORBA interfaces library
ii libbonoboui2-0 2.8.1-1 The Bonobo UI library
ii libc6 2.3.2.ds1-20 GNU C Library: Shared libraries an
ii libesd-alsa0 [libesd 0.2.35-2 Enlightened Sound Daemon (ALSA) -
ii libgail-common 1.8.2-1 GNOME Accessibility Implementation
ii libgail17 1.8.2-1 GNOME Accessibility Implementation
ii libgconf2-4 2.8.1-4 GNOME configuration database syste
ii libgcrypt11 1.2.0-11 LGPL Crypto library - runtime libr
ii libglade2-0 1:2.4.2-1 library to load .glade files at ru
ii libglib2.0-0 2.6.2-1 The GLib library of C routines
ii libgnome-keyring0 0.4.1-1 GNOME keyring services library
ii libgnome2-0 2.8.1-2 The GNOME 2 library - runtime file
ii libgnomecanvas2-0 2.8.0-1 A powerful object-oriented display
ii libgnomeui-0 2.8.1-1 The GNOME 2 libraries (User Interf
ii libgnomevfs2-0 2.8.4-1 The GNOME virtual file-system libr
ii libgnutls11 1.0.16-13 GNU TLS library - runtime library
ii libgpg-error0 1.0-1 library for common error values an
ii libgstreamer-gconf0. 0.8.7-3 GConf support for GStreamer
ii libgstreamer-plugins 0.8.7-3 Various GStreamer libraries and li
ii libgstreamer0.8-0 0.8.9-1 Core GStreamer libraries, plugins,
ii libgtk2.0-0 2.6.2-3 The GTK+ graphical user interface
ii libice6 4.3.0.dfsg.1-12.0.1 Inter-Client Exchange library
ii libjpeg62 6b-9 The Independent JPEG Group's JPEG
ii liborbit2 1:2.10.5-0.1 libraries for ORBit2 - a CORBA ORB
ii libpango1.0-0 1.8.0-3 Layout and rendering of internatio
ii libpopt0 1.7-5 lib for parsing cmdline parameters
ii libsm6 4.3.0.dfsg.1-12.0.1 X Window System Session Management
ii libtasn1-2 0.2.10-4 Manage ASN.1 structures (runtime)
ii libx11-6 4.3.0.dfsg.1-12.0.1 X Window System protocol client li
ii libxml2 2.6.16-3 GNOME XML library
ii xlibs 4.3.0.dfsg.1-12 X Keyboard Extension (XKB) configu
ii zlib1g 1:1.2.2-4 compression library - runtime
-- no debconf information
--===============0433565357==
Content-Type: text/x-c; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="patch-cddbslave-multiplematches.diff"
--- cddb-slave2/cddb-slave.c 2004-05-11 12:14:32.000000000 +0200
+++ cddb-slave2/cddb-slave.c.patched 2005-02-27 21:28:31.000000000 +0100
@@ -572,8 +572,8 @@
more = FALSE;
break;
+ case 210:
case 211:
- /* Should this be 210 as well? */
cs_debug ("Multiple matches found\n<-- %s", response);
if (response[0] == '.') {
--===============0433565357==--