Bug#281887: marked as done (add patches for pmount interoperability)
Debian Bug Tracking System
owner@bugs.debian.org
Sat, 08 Jan 2005 04:18:10 -0800
Your message dated Sat, 08 Jan 2005 13:07:07 +0100
with message-id <1105186028.10787.13.camel@localhost.localdomain>
and subject line Bug#281887: add patches for pmount interoperability
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 18 Nov 2004 11:42:25 +0000
>From sjoerd@luon.net Thu Nov 18 03:42:25 2004
Return-path: <sjoerd@luon.net>
Received: from simons.xs4all.nl (fire.luon.net) [80.126.201.244]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1CUkgC-0006jo-00; Thu, 18 Nov 2004 03:42:25 -0800
Received: from spring.luon.net (spring-wired.ipv6.luon.net [IPv6:2001:888:1d84:0:20a:95ff:fed1:4834])
by fire.luon.net (Postfix) with ESMTP id 7751559;
Thu, 18 Nov 2004 12:42:19 +0100 (CET)
Received: by spring.luon.net (Postfix, from userid 1000)
id 33F9837B29; Thu, 18 Nov 2004 12:42:15 +0100 (CET)
Content-Type: multipart/mixed; boundary="===============1311450179=="
MIME-Version: 1.0
From: Sjoerd Simons <sjoerd@luon.net>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: add patches for pmount interoperability
X-Mailer: reportbug 3.2
Date: Thu, 18 Nov 2004 12:42:15 +0100
Message-Id: <20041118114215.33F9837B29@spring.luon.net>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
This is a multi-part MIME message sent by reportbug.
--===============1311450179==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Package: gnome-vfs2
Severity: wishlist
Tags: patch
Hi,
I'm working on getting gnome-volume-manager and hal work correctly with
pmount, so there is no need to edit fstab.
Unfortunately volumes that are pmounted can't be unmounted by the user with
normal mount (no fstab entry) and aren't show on the desktop (gnome-vfs uses
fstab to decide that).
Two resolve these problems two patches are attached
09_pmount.patch:
Use pumount for unmounting if it exists. This is the same patch as in
the ubuntu gnome-vfs2 package, but improved a little to test if the command
is executable instead of just there. Thus for users not in the plugdev
group, umount is used even if pumount is available on the system.
12_user_visible_drives.patch:
Because they have no fstab entry, pmounted drives are not marked as
user-visible. The patch makes everything under /media user-visible, which
is where pmounts mount all it drives. Patch is taken directly from the
ubuntu package, so should be well tested.
Sjoerd
-- System Information:
Debian Release: 3.1
APT prefers unstable
APT policy: (500, 'unstable'), (101, 'experimental')
Architecture: powerpc (ppc)
Kernel: Linux 2.6.9-spring
Locale: LANG=C, LC_CTYPE=nl_NL@euro (charmap=ISO-8859-15)
--===============1311450179==
Content-Type: text/x-c; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="09_pmount.patch"
diff -Naur gnome-vfs2-2.8.3-old/libgnomevfs/gnome-vfs-volume-ops.c gnome-vfs2-2.8.3/libgnomevfs/gnome-vfs-volume-ops.c
--- gnome-vfs2-2.8.3-old/libgnomevfs/gnome-vfs-volume-ops.c 2004-11-18 11:39:58.000000000 +0100
+++ gnome-vfs2-2.8.3/libgnomevfs/gnome-vfs-volume-ops.c 2004-11-18 11:40:38.000000000 +0100
@@ -57,6 +57,7 @@
};
static const char *umount_known_locations [] = {
+ "/usr/bin/pumount", "/bin/pumount",
"/sbin/umount", "/bin/umount",
"/usr/sbin/umount", "/usr/bin/umount",
NULL
@@ -76,7 +77,7 @@
int i;
for (i = 0; known_locations [i]; i++){
- if (g_file_test (known_locations [i], G_FILE_TEST_EXISTS))
+ if (g_file_test (known_locations [i], G_FILE_TEST_IS_EXECUTABLE))
return known_locations [i];
}
return NULL;
@@ -339,7 +340,7 @@
name = mount_point;
}
#else
- name = mount_point;
+ name = device_path;
#endif
if (should_mount) {
--===============1311450179==
Content-Type: text/x-c; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="12_user_visible_drives.patch"
Nur in gnome-vfs2-2.8.1.old/debian/patches: 12_user_visible_drives.patch.
diff -ru gnome-vfs2-2.8.1.old/libgnomevfs/gnome-vfs-volume-monitor-daemon.c gnome-vfs2-2.8.1/libgnomevfs/gnome-vfs-volume-monitor-daemon.c
--- gnome-vfs2-2.8.1.old/libgnomevfs/gnome-vfs-volume-monitor-daemon.c 2004-09-23 15:20:46.099901960 +0200
+++ gnome-vfs2-2.8.1/libgnomevfs/gnome-vfs-volume-monitor-daemon.c 2004-09-23 15:23:00.649447320 +0200
@@ -954,6 +954,10 @@
vol->priv->is_user_visible = 1;
break;
default:
+ /* additionally mark devices below /media/ as user visible, in
+ * case they are not recognized as devices above */
+ if (!strncmp (mount->mount_path, "/media/", 7))
+ vol->priv->is_user_visible = 1;
break;
}
--===============1311450179==--
---------------------------------------
Received: (at 281887-done) by bugs.debian.org; 8 Jan 2005 12:07:35 +0000
>From seb128@debian.org Sat Jan 08 04:07:35 2005
Return-path: <seb128@debian.org>
Received: from smtp5.wanadoo.fr [193.252.22.26]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1CnFNX-0002UP-00; Sat, 08 Jan 2005 04:07:35 -0800
Received: from me-wanadoo.net (localhost [127.0.0.1])
by mwinf0502.wanadoo.fr (SMTP Server) with ESMTP id CFC5A1C00396
for <281887-done@bugs.debian.org>; Sat, 8 Jan 2005 13:07:04 +0100 (CET)
Received: from [192.168.0.2] (ANancy-151-1-34-104.w83-196.abo.wanadoo.fr [83.196.161.104])
by mwinf0502.wanadoo.fr (SMTP Server) with ESMTP id 9E2141C0038E
for <281887-done@bugs.debian.org>; Sat, 8 Jan 2005 13:07:02 +0100 (CET)
Subject: Re: Bug#281887: add patches for pmount interoperability
From: Sebastien Bacher <seb128@debian.org>
To: 281887-done@bugs.debian.org
In-Reply-To: <20041118114215.33F9837B29@spring.luon.net>
References: <20041118114215.33F9837B29@spring.luon.net>
Content-Type: text/plain; charset=ISO-8859-15
Date: Sat, 08 Jan 2005 13:07:07 +0100
Message-Id: <1105186028.10787.13.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.1.2
Content-Transfer-Encoding: quoted-printable
Delivered-To: 281887-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-4.8 required=4.0 tests=BAYES_00,FROM_ENDS_IN_NUMS,
HAS_BUG_NUMBER autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Le jeudi 18 novembre 2004 =E0 12:42 +0100, Sjoerd Simons a =E9crit :
> I'm working on getting gnome-volume-manager and hal work correctly wi=
th
> pmount, so there is no need to edit fstab.
These patches are in the sarge version now, bug closed.