Bug#285726: marked as done (gnome-vfs2: libhttp.so module causes instant crash on 64-bit machines)

Debian Bug Tracking System owner@bugs.debian.org
Sat, 08 Jan 2005 05:18:23 -0800


Your message dated Sat, 08 Jan 2005 08:02:14 -0500
with message-id <E1CnGEQ-0000y2-00@newraff.debian.org>
and subject line Bug#285726: fixed in gnome-vfs2 2.8.3-8
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 15 Dec 2004 05:13:18 +0000
>From David.Mosberger@acm.org Tue Dec 14 21:13:18 2004
Return-path: <David.Mosberger@acm.org>
Received: from adsl-66-127-195-58.dsl.snfc21.pacbell.net (panda.mostang.com) [66.127.195.58] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CeRTS-0001JU-00; Tue, 14 Dec 2004 21:13:18 -0800
Received: by panda.mostang.com (Postfix, from userid 199)
	id A204DD40AC; Tue, 14 Dec 2004 21:12:47 -0800 (PST)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: David Mosberger-Tang <David.Mosberger@acm.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: gnome-vfs2: libhttp.so module causes instant crash on 64-bit machines
X-Mailer: reportbug 3.2
Date: Tue, 14 Dec 2004 21:12:47 -0800
Message-Id: <20041215051247.A204DD40AC@panda.mostang.com>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Package: gnome-vfs2
Severity: normal
Tags: patch


It's very annoying when bug-buddy itself crashes.  At the moment, this
is what happens on any 64-bit machine because the libhttp module has
some 64-bit cleanliness issues.  In particular, there are two files
which call stpcpy().  Since the files are compiled without
-D_GNU_SOURCE, the routine ends up getting declared implicitly as
returning "int", which is deadly on 64-bit platforms.

The patch below is one way to fix the problem.  Another solution would
be to add -D_GNU_SOURCE to CPPFLAGS.  Either way is fine with me, as
long as the package gets fixed... ;-)

Thanks!

	--david

-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable')
Architecture: ia64
Kernel: Linux 2.6.10-rc2
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

---
diff -urN -x '*.lo' -x '*.la' -x .deps -x .libs gnome-vfs2-2.8.3-orig/imported/neon/ne_session.c gnome-vfs2-2.8.3/imported/neon/ne_session.c
--- gnome-vfs2-2.8.3-orig/imported/neon/ne_session.c	2004-07-02 07:52:12.000000000 -0700
+++ gnome-vfs2-2.8.3/imported/neon/ne_session.c	2004-12-14 20:54:54.744379416 -0800
@@ -23,6 +23,7 @@
 
 #include "config.h"
 
+#define _GNU_SOURCE
 #ifdef HAVE_STRING_H
 #include <string.h>
 #endif
diff -urN -x '*.lo' -x '*.la' -x .deps -x .libs gnome-vfs2-2.8.3-orig/imported/neon/ne_string.c gnome-vfs2-2.8.3/imported/neon/ne_string.c
--- gnome-vfs2-2.8.3-orig/imported/neon/ne_string.c	2004-07-24 07:39:43.000000000 -0700
+++ gnome-vfs2-2.8.3/imported/neon/ne_string.c	2004-12-14 20:57:11.293999272 -0800
@@ -21,6 +21,7 @@
 
 #include "config.h"
 
+#define _GNU_SOURCE
 #ifdef HAVE_STDLIB_H
 #include <stdlib.h>
 #endif

---------------------------------------
Received: (at 285726-close) by bugs.debian.org; 8 Jan 2005 13:08:57 +0000
>From katie@ftp-master.debian.org Sat Jan 08 05:08:57 2005
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CnGKu-00053s-00; Sat, 08 Jan 2005 05:08:57 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1CnGEQ-0000y2-00; Sat, 08 Jan 2005 08:02:14 -0500
From: Sebastien Bacher <seb128@debian.org>
To: 285726-close@bugs.debian.org
X-Katie: $Revision: 1.54 $
Subject: Bug#285726: fixed in gnome-vfs2 2.8.3-8
Message-Id: <E1CnGEQ-0000y2-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Sat, 08 Jan 2005 08:02:14 -0500
Delivered-To: 285726-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-4.8 required=4.0 tests=BAYES_00,FROM_ENDS_IN_NUMS,
	HAS_BUG_NUMBER autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Source: gnome-vfs2
Source-Version: 2.8.3-8

We believe that the bug you reported is fixed in the latest version of
gnome-vfs2, which is due to be installed in the Debian FTP archive:

gnome-vfs2_2.8.3-8.diff.gz
  to pool/main/g/gnome-vfs2/gnome-vfs2_2.8.3-8.diff.gz
gnome-vfs2_2.8.3-8.dsc
  to pool/main/g/gnome-vfs2/gnome-vfs2_2.8.3-8.dsc
libgnomevfs2-0_2.8.3-8_i386.deb
  to pool/main/g/gnome-vfs2/libgnomevfs2-0_2.8.3-8_i386.deb
libgnomevfs2-common_2.8.3-8_i386.deb
  to pool/main/g/gnome-vfs2/libgnomevfs2-common_2.8.3-8_i386.deb
libgnomevfs2-dev_2.8.3-8_i386.deb
  to pool/main/g/gnome-vfs2/libgnomevfs2-dev_2.8.3-8_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 285726@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sebastien Bacher <seb128@debian.org> (supplier of updated gnome-vfs2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat,  8 Jan 2005 13:00:05 +0100
Source: gnome-vfs2
Binary: libgnomevfs2-dev libgnomevfs2-0 libgnomevfs2-common
Architecture: source i386
Version: 2.8.3-8
Distribution: unstable
Urgency: medium
Maintainer: Takuo KITAME <kitame@debian.org>
Changed-By: Sebastien Bacher <seb128@debian.org>
Description: 
 libgnomevfs2-0 - The GNOME virtual file-system library (runtime files)
 libgnomevfs2-common - The GNOME virtual file-system library (common files)
 libgnomevfs2-dev - The GNOME virtual file-system library (development files)
Closes: 285726
Changes: 
 gnome-vfs2 (2.8.3-8) unstable; urgency=medium
 .
   * debian/patches/14_libhttp_64.patch:
     - patch from David Mosberger-Tang <David.Mosberger@acm.org> to fix a
       crasher on 64bits archs (Closes: #285726).
Files: 
 95ffc8854e54572244b953dd6193e8f3 1686 libs optional gnome-vfs2_2.8.3-8.dsc
 bd1ab5637a322c63b1d6948d881a96ae 11438 libs optional gnome-vfs2_2.8.3-8.diff.gz
 cdea0010ccc1508ad55bc39786ef42e0 1063578 devel optional libgnomevfs2-common_2.8.3-8_i386.deb
 5e13855db672c0984baa2e5b587bf110 400908 libs optional libgnomevfs2-0_2.8.3-8_i386.deb
 cbb2c7381a7ecc2cde6576b0460c71fd 474764 libdevel optional libgnomevfs2-dev_2.8.3-8_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFB39cbQxo87aLX0pIRAs6iAJ4rcfVcpTutZs9q1/LaO/9EUEuWMgCg6RVI
JOdXRbjWiqBxv3Pn1k9B2gk=
=6duE
-----END PGP SIGNATURE-----