Bug#260192: gedit: PATCH: premature free in egg-recent-view-gtk.c

[Loïc Minier]

        Hi,

Peter Moulder <Peter.Moulder@infotech.monash.edu.au> - Thu, Jan 20, 2005:

> I believe the patch was submitted on the basis of code inspection rathe=
r
> than experience: the buffer was being freed and then subsequently passe=
d
> to another function, i.e. passing an invalid pointer.

 This is how I understood it, based on your description and on the patch
 itself, but when it came to looking in the gedit source code,
 everything had changed...  :-/

> I haven't yet verified whether the patch is still relevant to the
> current version of gedit.

 It seems much work has happened since your patch in gedit's source
 code, and it's likely (but not certain) that upstream fixed the issue
 you wanted to patch, or simply rewrote that part.  I don't think
 upstream nor I are willing to understand all the changes involved since
 the old version of gedit against which the patch applied.

 What I propose is that:
 - we wait for the problem to show up again,
 - or you have a look at the current source code with respect to the
   intended fix of your patch.

 I had a short look at the file you wanted to patch, and I couldn't
 easily spot a misplaced free(), but may be you would?

 If you want to follow the second approach, I'll reopen this bug and
 wait for your comments.  For the first approach, we will wait for new
 bug reports.

 Thanks!

     Regards,

-- 
Loïc Minier <lool@dooz.org>
"Neutral President: I have no strong feelings one way or the other."