Bug#291185: gnome-panel: can't even create new custom launchers

[Sjoerd Simons]

--dDRMvlgZJXvWKvBx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

tag 291185 +patch
thanks,

Seems that we were cc the wrong bug report the whole time.. my fault (need to
get my brown paper bag)

On Thu, Jan 20, 2005 at 04:36:35PM +0100, M. Dietrich wrote:
> On Thu, Jan 20, 2005 at 04:09:04PM +0100, Sjoerd Simons wrote:
> > Please keep the bts in the CC list, so others can fellow the
> > progress..
> sorry - mutt usage error ;)
> > 
> > On Thu, Jan 20, 2005 at 03:42:32PM +0100, M. Dietrich wrote:
> > Works here... Could you tar /etc/gnome-vfs-2.0/vfolders and
> > ~/.gnome2/vfolders and send them over? They should have all the info
> > needed to track it down..
> shure, attached

gnome-panel's desktop reader didn't handle keys with empty value pairs the
right way. It actually worked through a bug in glib, which was fixed for 2.6 :)

Attached is a patch to fix it..

  Sjoerd
-- 
It is not that polar co-ordinates are complicated, it is simply
that cartesian co-ordinates are simpler than they have a right to be.
		-- Kleppner & Kolenhow, "An Introduction to Mechanics"

--dDRMvlgZJXvWKvBx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="empty-desktop-keys.patch"

diff -Naur gnome-panel-2.8.2.orig/gnome-panel/quick-desktop-reader.c gnome-panel-2.8.2/gnome-panel/quick-desktop-reader.c
--- gnome-panel-2.8.2.orig/gnome-panel/quick-desktop-reader.c	2005-01-20 21:51:45.000000000 +0100
+++ gnome-panel-2.8.2/gnome-panel/quick-desktop-reader.c	2005-01-20 22:20:33.000000000 +0100
@@ -100,6 +100,8 @@
 	p++;
 	if (*p == ' ')
 		p++;
+	if (*p == '\0')
+		return NULL;
 	return p;
 }
 /* nice wrapper for this to still allow some compiler optimization

--dDRMvlgZJXvWKvBx--