Bug#274027: marked as done (gconf2: FTFBS on hurd-i386:
Unconditional use of system limits not mandated by POSIX)
Debian Bug Tracking System
owner@bugs.debian.org
Tue Jul 12 23:03:07 UTC 2005
Your message dated Wed, 13 Jul 2005 00:46:51 +0200
with message-id <1121208411.4307.31.camel@mirchusko.localnet>
and subject line Fixed long time ago
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 29 Sep 2004 12:34:04 +0000
>From mbanck@gmx.net Wed Sep 29 05:34:04 2004
Return-path: <mbanck@gmx.net>
Received: from imap.gmx.net (mail.gmx.net) [213.165.64.20]
by spohr.debian.org with smtp (Exim 3.35 1 (Debian))
id 1CCdel-0001Wd-00; Wed, 29 Sep 2004 05:34:03 -0700
Received: (qmail 30972 invoked by uid 65534); 29 Sep 2004 12:33:32 -0000
Received: from socks-out.lrz-muenchen.de (EHLO nighthawk.oase.mhn.de) (129.187.254.15)
by mail.gmx.net (mp020) with SMTP; 29 Sep 2004 14:33:32 +0200
X-Authenticated: #686195
Received: from mbanck by nighthawk.oase.mhn.de with local (Exim 4.34)
id 1CCdeA-0000nr-63
for submit@bugs.debian.org; Wed, 29 Sep 2004 14:33:26 +0200
Date: Wed, 29 Sep 2004 14:33:26 +0200
From: Michael Banck <mbanck@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: gconf2: FTFBS on hurd-i386: Unconditional use of system limits not mandated by POSIX
Message-ID: <20040929123326.GA2871@nighthawk.oase.mhn.de>
Reply-To: Michael Banck <mbanck@debian.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="EeQfGwPcQSOJBaQU"
Content-Disposition: inline
X-Reportbug-Version: 2.99.3
User-Agent: Mutt/1.5.6+20040818i
Sender: Michael Banck <mbanck@gmx.net>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
--EeQfGwPcQSOJBaQU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Package: gconf2
Version: 2.6.4-2
Severity: important
Tags: patch
Hi,
gconf2 fails to build on hurd-i386 as PATH_MAX is not defined on GNU
Hurd. The GNU project/system does not impose arbitrary limits on its
users, and PATH_MAX is not mandated to be defined by POSIX. The right
fix would be to dynamically allocate enough memory to hold the paths,
but the attached patch will do for the time being. I built gconf2 with
it on GNU/Linux, and there were no issues.
If you report this upstream, please encourage them to properly fix this,
as GNU/Linux systems might also profit from directory variables being
actually only as large as needed, and not 4096 chars as PATH_MAX says. I
don't know how common these codepaths (backends/xml-dir.c and
backends/markup-tree.c) are though.
I can quote the build log if you want, I just don't have it handy right
now.
Michael
--EeQfGwPcQSOJBaQU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="gconf_path_max.diff"
diff -Naur GConf-2.6.4.orig/backends/markup-tree.c GConf-2.6.4/backends/markup-tree.c
--- GConf-2.6.4.orig/backends/markup-tree.c 2004-09-29 14:09:44.000000000 +0200
+++ GConf-2.6.4/backends/markup-tree.c 2004-09-29 14:14:01.000000000 +0200
@@ -33,6 +33,11 @@
#include <stdio.h>
#include <time.h>
+/* PATH_MAX is not defined in limits.h on some platforms */
+#ifndef PATH_MAX
+#define PATH_MAX 4096
+#endif
+
typedef struct
{
char *locale;
diff -Naur GConf-2.6.4.orig/backends/xml-dir.c GConf-2.6.4/backends/xml-dir.c
--- GConf-2.6.4.orig/backends/xml-dir.c 2004-09-29 14:09:44.000000000 +0200
+++ GConf-2.6.4/backends/xml-dir.c 2004-09-29 14:11:59.000000000 +0200
@@ -37,6 +37,11 @@
#include <gconf/gconf-internals.h>
#include "xml-entry.h"
+/* PATH_MAX is not defined in limits.h on some platforms */
+#ifndef PATH_MAX
+#define PATH_MAX 4096
+#endif
+
/* This makes hash table safer when debugging */
#ifndef GCONF_ENABLE_DEBUG
#define safe_g_hash_table_insert g_hash_table_insert
--EeQfGwPcQSOJBaQU--
---------------------------------------
Received: (at 274027-done) by bugs.debian.org; 12 Jul 2005 22:46:54 +0000
>From joss@debian.org Tue Jul 12 15:46:54 2005
Return-path: <joss@debian.org>
Received: from utena.malsain.org (mirchusko.localnet) [82.238.217.224]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DsTWg-0002Y0-00; Tue, 12 Jul 2005 15:46:54 -0700
Received: from joss by mirchusko.localnet with local (Exim 4.52)
id 1DsTWe-0003Xc-6l
for 274027-done@bugs.debian.org; Wed, 13 Jul 2005 00:46:52 +0200
Subject: Fixed long time ago
From: Josselin Mouette <joss@debian.org>
To: 274027-done@bugs.debian.org
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-9naipW5az/fU2E35bcv6"
Date: Wed, 13 Jul 2005 00:46:51 +0200
Message-Id: <1121208411.4307.31.camel@mirchusko.localnet>
Mime-Version: 1.0
X-Mailer: Evolution 2.2.2
Delivered-To: 274027-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
--=-9naipW5az/fU2E35bcv6
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
This patch was integrated in 2.8.4-1.
Regards,
--=20
.''`. Josselin Mouette /\./\
: :' : josselin.mouette@ens-lyon.org
`. `' joss@debian.org
`- Debian GNU/Linux -- The power of freedom
--=-9naipW5az/fU2E35bcv6
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQBC1EhbrSla4ddfhTMRAqUsAKCWFhY9v6T4keBOAieG0lODT6qb7gCfWEoj
FiY/5X6iN70t18owkG8wd6I=
=a/ve
-----END PGP SIGNATURE-----
--=-9naipW5az/fU2E35bcv6--
More information about the Pkg-gnome-maintainers
mailing list