Bug#318031: marked as done (segfault on amd64)
Debian Bug Tracking System
owner@bugs.debian.org
Thu Jul 14 12:03:25 UTC 2005
Your message dated Thu, 14 Jul 2005 07:47:09 -0400
with message-id <E1Dt2BJ-0003e5-00@newraff.debian.org>
and subject line Bug#307975: fixed in libgksu1.2 1.3.2-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 12 Jul 2005 23:52:06 +0000
>From aurel@gnuage.org Tue Jul 12 16:52:06 2005
Return-path: <aurel@gnuage.org>
Received: from postfix3-2.free.fr [213.228.0.169]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DsUXm-0002tu-00; Tue, 12 Jul 2005 16:52:06 -0700
Received: from marge.gnuage.org (4be54-4-82-234-153-242.fbx.proxad.net [82.234.153.242])
by postfix3-2.free.fr (Postfix) with ESMTP id 11F7CC025
for <submit@bugs.debian.org>; Wed, 13 Jul 2005 01:52:04 +0200 (CEST)
Received: from [2002:52ea:99f2:1:240:f4ff:fecb:81b1] (helo=homer.gnuage.org)
by marge.gnuage.org with esmtp (Exim 4.51)
id 1DsUiR-0002jy-E3
for submit@bugs.debian.org; Wed, 13 Jul 2005 02:03:09 +0200
Date: Wed, 13 Jul 2005 01:52:01 +0200
From: Aurelien Jacobs <aurel@gnuage.org>
To: submit@bugs.debian.org
Message-ID: <20050713015201.79b22177@homer.gnuage.org>
X-Mailer: Sylpheed-Claws 1.0.4 (GTK+ 1.2.10; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: multipart/mixed;
boundary="Multipart_Wed__13_Jul_2005_01_52_01_+0200_ce7JTr/arUa9ZVNh"
X-SA-Exim-Connect-IP: 2002:52ea:99f2:1:240:f4ff:fecb:81b1
X-SA-Exim-Mail-From: aurel@gnuage.org
Subject: segfault on amd64
X-SA-Exim-Version: 4.2 (built Thu, 03 Mar 2005 10:44:12 +0100)
X-SA-Exim-Scanned: Yes (on marge.gnuage.org)
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
--Multipart_Wed__13_Jul_2005_01_52_01_+0200_ce7JTr/arUa9ZVNh
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Package: libgksu1.2
Version: 1.3.1-1
Severity: important
Tags: patch
Currently, libgksu defines a callback function (keyring_create_item_cb)
inside another function. The problem is that this callback function
is stored on the stack (like any other local variable). amd64 has this
famous NX flag which prevent execution of the stack. So when the
callback stored on the stack is called, it simply segfault.
The fix is very simple: move keyring_create_item_cb callback definition
outside of the function.
The attached patch fix this issue.
BTW: this patch should also close #307975
Aurel
--Multipart_Wed__13_Jul_2005_01_52_01_+0200_ce7JTr/arUa9ZVNh
Content-Type: text/plain; name=libgksu-amd64.diff
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=libgksu-amd64.diff
--- libgksu/gksu-context.c.orig 2005-07-13 01:29:24.000000000 +0200
+++ libgksu/gksu-context.c 2005-07-13 01:30:36.000000000 +0200
@@ -784,6 +784,13 @@
return TRUE;
}
+static void
+keyring_create_item_cb (GnomeKeyringResult result,
+ guint32 id, gpointer keyring_loop)
+{
+ g_main_loop_quit (keyring_loop);
+}
+
/**
* gksu_context_run:
* @context: a #GksuContext
@@ -989,20 +996,14 @@
keyring_loop = g_main_loop_new (NULL, FALSE);
- void
- keyring_create_item_cb (GnomeKeyringResult result,
- guint32 id, gpointer data)
- {
- g_main_loop_quit (keyring_loop);
- }
-
gnome_keyring_item_create (NULL,
GNOME_KEYRING_ITEM_GENERIC_SECRET,
key_name,
attributes,
gksu_context_get_password (context),
TRUE,
- keyring_create_item_cb, NULL, NULL);
+ keyring_create_item_cb,
+ keyring_loop, NULL);
gnome_keyring_attribute_list_free (attributes);
g_main_loop_run (keyring_loop);
}
--Multipart_Wed__13_Jul_2005_01_52_01_+0200_ce7JTr/arUa9ZVNh--
---------------------------------------
Received: (at 307975-close) by bugs.debian.org; 14 Jul 2005 11:53:10 +0000
>From katie@ftp-master.debian.org Thu Jul 14 04:53:10 2005
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1Dt2H8-0006QQ-00; Thu, 14 Jul 2005 04:53:10 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1Dt2BJ-0003e5-00; Thu, 14 Jul 2005 07:47:09 -0400
From: Gustavo Noronha Silva <kov@debian.org>
To: 307975-close@bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#307975: fixed in libgksu1.2 1.3.2-1
Message-Id: <E1Dt2BJ-0003e5-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Thu, 14 Jul 2005 07:47:09 -0400
Delivered-To: 307975-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Source: libgksu1.2
Source-Version: 1.3.2-1
We believe that the bug you reported is fixed in the latest version of
libgksu1.2, which is due to be installed in the Debian FTP archive:
libgksu1.2-0_1.3.2-1_i386.deb
to pool/main/libg/libgksu1.2/libgksu1.2-0_1.3.2-1_i386.deb
libgksu1.2-dev_1.3.2-1_i386.deb
to pool/main/libg/libgksu1.2/libgksu1.2-dev_1.3.2-1_i386.deb
libgksu1.2_1.3.2-1.diff.gz
to pool/main/libg/libgksu1.2/libgksu1.2_1.3.2-1.diff.gz
libgksu1.2_1.3.2-1.dsc
to pool/main/libg/libgksu1.2/libgksu1.2_1.3.2-1.dsc
libgksu1.2_1.3.2.orig.tar.gz
to pool/main/libg/libgksu1.2/libgksu1.2_1.3.2.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 307975@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Gustavo Noronha Silva <kov@debian.org> (supplier of updated libgksu1.2 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Thu, 14 Jul 2005 13:48:05 +0300
Source: libgksu1.2
Binary: libgksu1.2-dev libgksu1.2-0
Architecture: source i386
Version: 1.3.2-1
Distribution: unstable
Urgency: low
Maintainer: Gustavo Noronha Silva <kov@debian.org>
Changed-By: Gustavo Noronha Silva <kov@debian.org>
Description:
libgksu1.2-0 - library providing su and sudo functionality
libgksu1.2-dev - library providing su and sudo functionality (development files)
Closes: 307975 309563 314369 318031
Changes:
libgksu1.2 (1.3.2-1) unstable; urgency=low
.
* The "Helsinki" Release
* New Upstream Release
- fixes wording of the xauth warning message (Closes: #309563)
- no longer crashes on AMD64 because of gnome-keyring
(Closes: #318031, #307975, #314369)
* debian/libgksu1.2-0.shlibs:
- make packages built with this version Depend on >= 1.3.2,
as new public API were added
* debian/control.in:
- increased Standards-Version with no modifications
Files:
fa414abfc0a1d4eaa76d9071960e94dd 1584 admin optional libgksu1.2_1.3.2-1.dsc
67ff3273026c6c81bf20e0821f3f5019 576459 admin optional libgksu1.2_1.3.2.orig.tar.gz
c64d17390b4db78dcf6132da185cd52a 7728 admin optional libgksu1.2_1.3.2-1.diff.gz
6ba1a0be3d394a2d038c9e2255c84722 35426 libs optional libgksu1.2-0_1.3.2-1_i386.deb
b046a41b123eae47af2e134553ae63d1 27056 libdevel optional libgksu1.2-dev_1.3.2-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFC1kzTt1anjIgqbEsRAmH1AKDCH2wCn5qOc+ViBQh58LxtVUL5mgCeIfsI
Bq3BbvhGe3rTlcpZORRykxY=
=JwfT
-----END PGP SIGNATURE-----
More information about the Pkg-gnome-maintainers
mailing list