Bug#320114: vte_terminal_set_colors doesn't accept 24 colors

[Ethan Glasser-Camp]

Package: libvte-dev
Version: 0.11.13-2

The documentation for the VTE widget says, under set_colors:

"palette_size must be either 0, 8, 16, or 24."

However, on vte.c, line 6692, in vte_terminal_set_colors, you can see the assertion:

g_return_if_fail((palette_size == 0) ||
			 (palette_size == 8) ||
			 (palette_size == 16) ||
			 (palette_size == G_N_ELEMENTS(terminal->pvt->palette)));

if palette_size is 24, you get a warning:

CRITICAL **: vte_terminal_set_colors: assertion `(palette_size == 0) ||
(palette_size == 8) || (palette_size == 16) || (palette_size ==
G_N_ELEMENTS(terminal->pvt->palette))' failed

You can work around this, because if you know how VteTerminal stores its
palette, you can just create a 30-color palette with all the colors in the right
place, but this is a hack.

I think that the return_if_fail should have another condition added, which is
palette_size == 24.

Ethan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20050726/49567dc8/signature.pgp