Bug#312250: marked as done (Setting DEB_CONFIGURE_SCRIPT_ENV overwrites default CFLAGS)
Debian Bug Tracking System
owner@bugs.debian.org
Mon, 06 Jun 2005 16:18:14 -0700
Your message dated Mon, 06 Jun 2005 19:03:02 -0400
with message-id <E1DfQcY-0007n1-00@newraff.debian.org>
and subject line Bug#312250: fixed in gamin 0.1.0-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 6 Jun 2005 17:58:49 +0000
>From michael.banck@ch.tum.de Mon Jun 06 10:58:49 2005
Return-path: <michael.banck@ch.tum.de>
Received: from server.theo.chemie.tu-muenchen.de [129.187.122.133]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DfLs9-0007p2-00; Mon, 06 Jun 2005 10:58:49 -0700
Received: by xserver.theo.chemie.tu-muenchen.de (Postfix, from userid 557)
id B4E509A352; Mon, 6 Jun 2005 19:58:16 +0200 (CEST)
Date: Mon, 6 Jun 2005 19:58:16 +0200
From: Michael Banck <mbanck@debian.org>
To: submit@bugs.debian.org
Subject: Setting DEB_CONFIGURE_SCRIPT_ENV overwrites default CFLAGS
Message-ID: <20050606175816.GA15490@theo.chemie.tu-muenchen.de>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="gKMricLos+KVdGMg"
Content-Disposition: inline
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.4 required=4.0 tests=BAYES_00,HAS_PACKAGE,
UPPERCASE_25_50 autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
--gKMricLos+KVdGMg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Package: gamin
Severity: normal
Version: 0.0.26-1
Tags: patch
Hi,
I was wondering why setting DEB_BUILD_OPTIONS=noopt does not work with
gamin and looked around a bit in CDBS. It turned out that debian/rules
has this bit:
DEB_CONFIGURE_SCRIPT_ENV := LDFLAGS="-Wl,-O1"
However, DEB_CONFIGURE_SCRIPT_ENV usually holds the default variables,
like CFLAGS; CXXFLAGS and so on (from 1/class/autotools-vars.mk):
DEB_CONFIGURE_SCRIPT_ENV = CC="$(CC)" CXX="$(CXX)" CFLAGS="$(CFLAGS)"
CXXFLAGS="$(CXXFLAGS)"
which get overwritten and later not set anymore currently:
if test ""; then cd ""; else cd "."; fi && LDFLAGS="-Wl,-O1"
/build/mbanck/gamin-0.0.26/./configure
Thus, I propose to not use the := operator, but rather += which should
simply append LDFLAGS to the others. This leads to the desired effect:
if test ""; then cd ""; else cd "."; fi && CC="cc" CXX="g++" CFLAGS="-g
-Wall -O2" CXXFLAGS="-g -Wall -O2" LDFLAGS="-Wl,-O1"
/build/mbanck/gamin-0.0.26/./configure
trivial patch attached.
cheers,
Michael
--gKMricLos+KVdGMg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="gamin.rules.diff"
--- debian/rules.orig 2005-06-06 21:56:10.000000000 +0200
+++ debian/rules 2005-06-06 19:48:24.000000000 +0200
@@ -8,7 +8,7 @@
include /usr/share/cdbs/1/class/gnome.mk
DEB_CONFIGURE_EXTRA_FLAGS := --disable-inotify
-DEB_CONFIGURE_SCRIPT_ENV := LDFLAGS="-Wl,-O1"
+DEB_CONFIGURE_SCRIPT_ENV += LDFLAGS="-Wl,-O1"
DEB_INSTALL_DOCS_ALL :=
DEB_INSTALL_DOCS_gamin := AUTHORS NEWS README TODO
--gKMricLos+KVdGMg--
---------------------------------------
Received: (at 312250-close) by bugs.debian.org; 6 Jun 2005 23:08:05 +0000
>From katie@ftp-master.debian.org Mon Jun 06 16:08:05 2005
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DfQhQ-0004H3-00; Mon, 06 Jun 2005 16:08:04 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1DfQcY-0007n1-00; Mon, 06 Jun 2005 19:03:02 -0400
From: Sjoerd Simons <sjoerd@debian.org>
To: 312250-close@bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#312250: fixed in gamin 0.1.0-1
Message-Id: <E1DfQcY-0007n1-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Mon, 06 Jun 2005 19:03:02 -0400
Delivered-To: 312250-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
X-CrossAssassin-Score: 2
Source: gamin
Source-Version: 0.1.0-1
We believe that the bug you reported is fixed in the latest version of
gamin, which is due to be installed in the Debian FTP archive:
gamin_0.1.0-1.diff.gz
to pool/main/g/gamin/gamin_0.1.0-1.diff.gz
gamin_0.1.0-1.dsc
to pool/main/g/gamin/gamin_0.1.0-1.dsc
gamin_0.1.0-1_powerpc.deb
to pool/main/g/gamin/gamin_0.1.0-1_powerpc.deb
gamin_0.1.0.orig.tar.gz
to pool/main/g/gamin/gamin_0.1.0.orig.tar.gz
libgamin-dev_0.1.0-1_powerpc.deb
to pool/main/g/gamin/libgamin-dev_0.1.0-1_powerpc.deb
libgamin0_0.1.0-1_powerpc.deb
to pool/main/g/gamin/libgamin0_0.1.0-1_powerpc.deb
python2.3-gamin_0.1.0-1_powerpc.deb
to pool/main/g/gamin/python2.3-gamin_0.1.0-1_powerpc.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 312250@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Sjoerd Simons <sjoerd@debian.org> (supplier of updated gamin package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Tue, 7 Jun 2005 00:27:11 +0200
Source: gamin
Binary: gamin python2.3-gamin libgamin0 libgamin-dev
Architecture: source powerpc
Version: 0.1.0-1
Distribution: unstable
Urgency: low
Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
Changed-By: Sjoerd Simons <sjoerd@debian.org>
Description:
gamin - File and directory monitoring system
libgamin-dev - Development files for the gamin client library
libgamin0 - Client library for the gamin file and directory monitoring system
python2.3-gamin - Python binding for the gamin client library
Closes: 311000 312250
Changes:
gamin (0.1.0-1) unstable; urgency=low
.
* New upstream release
* Also Provide/Replace and Conflict with libfam0, just like libfam0c102
does. (Closes: #311000)
* Use DEB_CONFIGURE_SCRIPT_ENV += instead of := (Thanks to Michael Bank for
catching this) (Closes: #312250)
* debian/patches/01_no_auto_deregister.patch
+ Removed. Can't reproduce the problem anymore with the new upstream
release.
Files:
6182fcf93fd38029f4d36b47ca7fa129 1508 admin optional gamin_0.1.0-1.dsc
282f34278af3367150e163136382d22d 498055 admin optional gamin_0.1.0.orig.tar.gz
21a3612c331027feb556c3f564e9a142 2782 admin optional gamin_0.1.0-1.diff.gz
17ca62e0c7c4e45fbabc8b6d16f3e8f3 39990 admin optional gamin_0.1.0-1_powerpc.deb
7202a67c2d25cba038bee808a9e4dd75 27926 libs optional libgamin0_0.1.0-1_powerpc.deb
7da1dd4b896a1de9a70d397151e0fc68 46222 libdevel optional libgamin-dev_0.1.0-1_powerpc.deb
f43287d5dfbd29d3ab735d19a691bcec 21366 python optional python2.3-gamin_0.1.0-1_powerpc.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFCpNCsgTd+SodosdIRAnWxAKC157HCgcvWvEFJO2Tir4UM8xq+JQCdEqYP
4Zg1NQxvP3IB11soO693QC8=
=I8nT
-----END PGP SIGNATURE-----