Bug#314692: gnome-panel: implicitly converted pointers

dann frazier dann frazier <dannf@hp.com>, 314692@bugs.debian.org
Fri, 17 Jun 2005 14:05:47 -0600


Package: gnome-panel
Version: 2.10.1-3
Severity: important
Tags: patch

Our build log filter[1] detected a problem that will cause your package to
segfault on architectures where the size of a pointer is greater
than the size of an integer, such as ia64.

Function `gnome_vfs_unescape_string_for_display' implicitly converted to pointer at panel.c:523
Function `getenv' implicitly converted to pointer at clock.c:333

The following patch fixes these issues by adding some missing includes.

[1]http://people.debian.org/~dannf/check-implicit-pointer-functions

diff -urN gnome-panel-2.10.1.orig/applets/clock/clock.c gnome-panel-2.10.1/applets/clock/clock.c
--- gnome-panel-2.10.1.orig/applets/clock/clock.c	2005-03-07 07:15:15.000000000 -0700
+++ gnome-panel-2.10.1/applets/clock/clock.c	2005-06-17 13:44:44.149885607 -0600
@@ -41,6 +41,7 @@
 
 #include "config.h"
 
+#include <stdlib.h>
 #include <stdio.h>
 #include <sys/stat.h>
 #include <unistd.h>
diff -urN gnome-panel-2.10.1.orig/gnome-panel/panel.c gnome-panel-2.10.1/gnome-panel/panel.c
--- gnome-panel-2.10.1.orig/gnome-panel/panel.c	2005-03-31 13:05:04.000000000 -0700
+++ gnome-panel-2.10.1/gnome-panel/panel.c	2005-06-17 13:43:21.107894436 -0600
@@ -23,6 +23,7 @@
 #include <libgnomevfs/gnome-vfs-ops.h>
 #include <libgnomevfs/gnome-vfs-mime-handlers.h>
 #include <libgnomevfs/gnome-vfs-file-info.h>
+#include <libgnomevfs/gnome-vfs-utils.h>
 
 #include "panel.h"
 

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: ia64
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.8-2-mckinley
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages gnome-panel depends on:
ii  gnome-about              2.10.1-2        The GNOME about box
ii  gnome-control-center     1:2.10.1-3      The GNOME Control Center for GNOME
ii  gnome-desktop-data       2.10.1-2        Common files for GNOME 2 desktop a
ii  gnome-menus              2.10.1-3        an implementation of the freedeskt
ii  gnome-panel-data         2.10.1-3        common files for GNOME 2 panel
ii  gnome-session            2.10.0-4        The GNOME 2 Session Manager
ii  libart-2.0-2             2.3.17-1        Library of functions for 2D graphi
ii  libatk1.0-0              1.10.1-2        The ATK accessibility toolkit
ii  libbonobo2-0             2.8.1-2         Bonobo CORBA interfaces library
ii  libbonoboui2-0           2.8.1-2         The Bonobo UI library
ii  libc6.1                  2.3.2.ds1-22    GNU C Library: Shared libraries an
ii  libecal1.2-2             1.2.2-5.1       Client library for evolution calen
ii  libedataserver1.2-4      1.2.2-5.1       Utily library for evolution data s
ii  libgconf2-4              2.10.0-2        GNOME configuration database syste
ii  libglade2-0              1:2.5.1-2       library to load .glade files at ru
ii  libglib2.0-0             2.6.5-1         The GLib library of C routines
ii  libgnome-desktop-2       2.10.1-2        Utility library for loading .deskt
ii  libgnome-menu0           2.10.1-3        an implementation of the freedeskt
ii  libgnome2-0              2.10.0-3        The GNOME 2 library - runtime file
ii  libgnomecanvas2-0        2.10.2-2        A powerful object-oriented display
ii  libgnomeui-0             2.10.0-2        The GNOME 2 libraries (User Interf
ii  libgnomevfs2-0           2.10.1-4        The GNOME virtual file-system libr
ii  libgtk2.0-0              2.6.7-2         The GTK+ graphical user interface 
ii  libice6                  4.3.0.dfsg.1-14 Inter-Client Exchange library
ii  liborbit2                1:2.12.2-1      libraries for ORBit2 - a CORBA ORB
ii  libpanel-applet2-0       2.10.1-3        library for GNOME 2 panel applets
ii  libpango1.0-0            1.8.1-1         Layout and rendering of internatio
ii  libpopt0                 1.7-5           lib for parsing cmdline parameters
ii  libsm6                   4.3.0.dfsg.1-14 X Window System Session Management
ii  libstartup-notification0 0.8-1           library for program launch feedbac
ii  libwnck16                2.10.0-2        Window Navigator Construction Kit 
ii  libx11-6                 4.3.0.dfsg.1-14 X Window System protocol client li
ii  libxml2                  2.6.16-7        GNOME XML library
ii  xlibs                    4.3.0.dfsg.1-14 X Keyboard Extension (XKB) configu
ii  zlib1g                   1:1.2.2-4       compression library - runtime

Versions of packages gnome-panel recommends:
ii  gnome-applets                 2.10.1-3   Various applets for GNOME 2 panel 

Versions of packages gnome-panel is related to:
ii  reportbug                     3.13       reports bugs in the Debian distrib
pn  totem-gstreamer               <none>     (no description available)

-- no debconf information