Bug#306040: marked as done (dia: Please include patch to fix
display references)
Debian Bug Tracking System
owner@bugs.debian.org
Sat, 18 Jun 2005 13:03:21 -0700
Your message dated Sat, 18 Jun 2005 15:47:58 -0400
with message-id <E1DjjIM-0003Uz-00@newraff.debian.org>
and subject line Bug#306040: fixed in dia 0.94.0-11
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 23 Apr 2005 21:59:37 +0000
>From hcauwelier@oursours.net Sat Apr 23 14:59:37 2005
Return-path: <hcauwelier@oursours.net>
Received: from nash.numericable.net [80.236.3.115]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DPSf3-0002j5-00; Sat, 23 Apr 2005 14:59:37 -0700
Received: (qmail 18299 invoked from network); 23 Apr 2005 21:59:05 -0000
Received: from unknown (HELO [192.168.1.2]) ([81.220.179.3])
(envelope-sender <hcauwelier@oursours.net>)
by nash.numericable.net (qmail-ldap-1.03) with SMTP
for <submit@bugs.debian.org>; 23 Apr 2005 21:59:05 -0000
Message-ID: <426AC533.2040906@oursours.net>
Date: Sat, 23 Apr 2005 23:59:15 +0200
From: =?ISO-8859-15?Q?Herv=E9_Cauwelier?= <hcauwelier@oursours.net>
Organization: GrandeOurse
User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050404)
X-Accept-Language: fr, en
MIME-Version: 1.0
To: submit@bugs.debian.org
Subject: dia: Please include patch to fix display references
X-Enigmail-Version: 0.90.0.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/mixed;
boundary="------------080601060405030201040009"
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
This is a multi-part message in MIME format.
--------------080601060405030201040009
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 8bit
Package: dia
Severity: wishlist
Tags: patch
Quoting Hans Breuer <hans@breuer.org>:
"* app/display.c : stop special casing the first display of
a diagram. Every display now has it's own refernce. The initial
reference gets dropped when there is no display anymore. See
diagram_remove_ddisplay(). Fixes bug #300744."
The change is attached as a dpatch file.
--
Hervé Cauwelier
http://www.oursours.net/
--------------080601060405030201040009
Content-Type: text/plain;
name="02_stop-special-casing-the-first-display-of-a-diagram.dpatch"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline;
filename="02_stop-special-casing-the-first-display-of-a-diagram.dpatch"
#! /bin/sh /usr/share/dpatch/dpatch-run
## 02_stop-special-casing-the-first-display-of-a-diagram.dpatch by Hervé Cauwelier <hcauwelier@oursours.net>
##
## All lines beginning with `## DP:' are a description of the patch.
## DP: No description.
@DPATCH@
diff -urNad dia-0.94.0/app/display.c /tmp/dpep.FoO912/dia-0.94.0/app/display.c
--- dia-0.94.0/app/display.c 2004-08-16 09:56:03.000000000 +0200
+++ /tmp/dpep.FoO912/dia-0.94.0/app/display.c 2005-04-23 20:02:56.961314800 +0200
@@ -131,8 +131,7 @@
memset (&ddisp->updatable_menu_items, 0, sizeof (UpdatableMenuItems));
ddisp->diagram = dia;
- if (dia->display_count > 1)
- /* The first display gets the initial ref */
+ /* Every display has it's own reference */
g_object_ref(dia);
ddisp->grid.visible = prefs.grid.visible;
--------------080601060405030201040009--
---------------------------------------
Received: (at 306040-close) by bugs.debian.org; 18 Jun 2005 19:51:48 +0000
>From katie@ftp-master.debian.org Sat Jun 18 12:51:48 2005
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DjjM4-0007WP-00; Sat, 18 Jun 2005 12:51:48 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1DjjIM-0003Uz-00; Sat, 18 Jun 2005 15:47:58 -0400
From: Roland Stigge <stigge@antcom.de>
To: 306040-close@bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#306040: fixed in dia 0.94.0-11
Message-Id: <E1DjjIM-0003Uz-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Sat, 18 Jun 2005 15:47:58 -0400
Delivered-To: 306040-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
X-CrossAssassin-Score: 7
Source: dia
Source-Version: 0.94.0-11
We believe that the bug you reported is fixed in the latest version of
dia, which is due to be installed in the Debian FTP archive:
dia-common_0.94.0-11_all.deb
to pool/main/d/dia/dia-common_0.94.0-11_all.deb
dia-gnome_0.94.0-11_i386.deb
to pool/main/d/dia/dia-gnome_0.94.0-11_i386.deb
dia-libs_0.94.0-11_i386.deb
to pool/main/d/dia/dia-libs_0.94.0-11_i386.deb
dia_0.94.0-11.diff.gz
to pool/main/d/dia/dia_0.94.0-11.diff.gz
dia_0.94.0-11.dsc
to pool/main/d/dia/dia_0.94.0-11.dsc
dia_0.94.0-11_i386.deb
to pool/main/d/dia/dia_0.94.0-11_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 306040@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Roland Stigge <stigge@antcom.de> (supplier of updated dia package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Fri, 17 Jun 2005 19:25:03 +0200
Source: dia
Binary: dia-libs dia-common dia-gnome dia
Architecture: source i386 all
Version: 0.94.0-11
Distribution: unstable
Urgency: low
Maintainer: Roland Stigge <stigge@antcom.de>
Changed-By: Roland Stigge <stigge@antcom.de>
Description:
dia - Diagram editor
dia-common - Diagram editor (common files)
dia-gnome - Diagram editor (GNOME version)
dia-libs - Diagram editor (library files)
Closes: 270547 305521 306036 306040 306041 306042 310980 311401 313687
Changes:
dia (0.94.0-11) unstable; urgency=low
.
* po/de.po: Applied translation fixes patch by Jens Seidel (Closes: #313687)
.
dia (0.94.0-10) experimental; urgency=low
.
* po/pl.po: Fixed Object menu translations, thanks to Marcin Owsiany
(Closes: #311401)
.
dia (0.94.0-9) experimental; urgency=low
.
* po/es.po: Fixed menu accelerators, thanks to Roberto C. Sanchez
(Closes: #310980)
.
dia (0.94.0-8) experimental; urgency=low
.
* debian/control: Added dpatch to Build-Depends
* Included dpatch based on the one by komar@ukr.net fixing .png references
in sheet files which are now .xpm references (Closes: #270547)
* Included the following dpatches by Hervé Cauwelier
<hcauwelier@oursours.net>:
- fix-another-crash-with-line-wrapping-code (Closes: #306042)
- fix-image-rendering-endianess (Closes: #306041)
- stop-special-casing-the-first-display-of-a-diagram (Closes: #306040)
- GCC 4 fixes: user-lib-prefix, fix-static-parse-path (Closes: #305521)
- locale-usage (Closes: #306036)
Files:
7ced12c0c6a2f810a6db684dcc53b512 1405 graphics optional dia_0.94.0-11.dsc
a086cd2ff1b8a5eeb6aa0bf7bdc7469b 28289 graphics optional dia_0.94.0-11.diff.gz
b972827d274d90f856cee1ef2e6a045b 2149296 graphics optional dia-common_0.94.0-11_all.deb
50ce0e4b9f6dde04117327794e5a6c7f 584770 graphics optional dia-libs_0.94.0-11_i386.deb
a1bc6166699fc2514f82936d1f216f6e 186762 graphics optional dia_0.94.0-11_i386.deb
c6f25c1e5f05f58df88e795f2f539fef 188286 gnome optional dia-gnome_0.94.0-11_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFCsw91caH/YBv43g8RAhl8AJ0XEQ3Jxt2KcMOsiRpi6aSP3bttyACgrwzo
U4YUn/aEJ0Gl61FrMgIomtw=
=G/Kk
-----END PGP SIGNATURE-----