Bug#308536: marked as done (Crash when creating new profile)
Debian Bug Tracking System
owner at bugs.debian.org
Tue Oct 25 15:18:15 UTC 2005
Your message dated Tue, 25 Oct 2005 08:02:06 -0700
with message-id <E1EUQJS-0003D7-00 at spohr.debian.org>
and subject line Bug#308536: fixed in gnome-media 2.10.2-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 10 May 2005 20:41:05 +0000
>From ross at burtonini.com Tue May 10 13:41:05 2005
Return-path: <ross at burtonini.com>
Received: from smtp.nildram.co.uk [195.112.4.54]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DVbXN-0007Q2-00; Tue, 10 May 2005 13:41:05 -0700
Received: from burtonini.com (62-3-249-205.dyn.gotadsl.co.uk [62.3.249.205])
by smtp.nildram.co.uk (Postfix) with ESMTP id DDA6A25E965
for <submit at bugs.debian.org>; Tue, 10 May 2005 21:40:59 +0100 (BST)
Received: from 127.0.0.1 (ident=unknown) by burtonini.com with esmtp
(masqmail 0.2.20) id 1DVbXK-8UG-00 for <submit at bugs.debian.org>; Tue,
10 May 2005 21:41:02 +0100
Subject: Crash when creating new profile
From: Ross Burton <ross at burtonini.com>
To: submit at bugs.debian.org
Content-Type: multipart/mixed; boundary="=-gndGCW2r2+moWWJn65j/"
Date: Tue, 10 May 2005 21:41:02 +0100
Message-Id: <1115757662.32430.1.camel at localhost>
Mime-Version: 1.0
X-Mailer: Evolution 2.2.2
Delivered-To: submit at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-7.0 required=4.0 tests=BAYES_01,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
--=-gndGCW2r2+moWWJn65j/
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Package: gnome-media
Version: 2.8.0-0.3
Tags: patch
When creating a new profile an invalid iterator is dereferenced, which
causes a segfault. Attached patch fixes this (I'm about to NMU).
Ross
--
Ross Burton mail: ross at burtonini.com
jabber: ross at burtonini.com
www: http://www.burtonini.com./
PGP Fingerprint: 1A21 F5B0 D8D0 CFE3 81D4 E25A 2D09 E447 D0B4 33DF
--=-gndGCW2r2+moWWJn65j/
Content-Disposition: attachment; filename=fix-iter.diff
Content-Type: text/x-patch; name=fix-iter.diff; charset=UTF-8
Content-Transfer-Encoding: 7bit
Index: profiles/audio-profile-choose.c
===================================================================
RCS file: /cvs/gnome/gnome-media/profiles/audio-profile-choose.c,v
retrieving revision 1.8
diff -u -r1.8 audio-profile-choose.c
--- profiles/audio-profile-choose.c 6 Nov 2004 22:41:19 -0000 1.8
+++ profiles/audio-profile-choose.c 15 Feb 2005 15:33:20 -0000
@@ -85,18 +85,18 @@
GtkTreeIter iter;
GtkComboBox *combo = GTK_COMBO_BOX (choose);
gchar *id;
- GMAudioProfile *profile;
+ GMAudioProfile *profile = NULL;
g_return_val_if_fail (GTK_IS_COMBO_BOX (choose), NULL);
/* get active id */
- gtk_combo_box_get_active_iter (combo, &iter);
- gtk_tree_model_get (gtk_combo_box_get_model (combo), &iter,
- ID_COLUMN, &id, -1);
-
- /* look up gm_audio profile */
- profile = gm_audio_profile_lookup (id);
- g_free (id);
-
+ if (gtk_combo_box_get_active_iter (combo, &iter)) {
+ gtk_tree_model_get (gtk_combo_box_get_model (combo), &iter,
+ ID_COLUMN, &id, -1);
+
+ /* look up gm_audio profile */
+ profile = gm_audio_profile_lookup (id);
+ g_free (id);
+ }
return profile;
}
--=-gndGCW2r2+moWWJn65j/--
---------------------------------------
Received: (at 308536-close) by bugs.debian.org; 25 Oct 2005 15:09:07 +0000
>From katie at spohr.debian.org Tue Oct 25 08:09:07 2005
Return-path: <katie at spohr.debian.org>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
id 1EUQJS-0003D7-00; Tue, 25 Oct 2005 08:02:06 -0700
From: Gustavo Noronha Silva <kov at debian.org>
To: 308536-close at bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#308536: fixed in gnome-media 2.10.2-1
Message-Id: <E1EUQJS-0003D7-00 at spohr.debian.org>
Sender: Archive Administrator <katie at spohr.debian.org>
Date: Tue, 25 Oct 2005 08:02:06 -0700
Delivered-To: 308536-close at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
Source: gnome-media
Source-Version: 2.10.2-1
We believe that the bug you reported is fixed in the latest version of
gnome-media, which is due to be installed in the Debian FTP archive:
gnome-media_2.10.2-1.diff.gz
to pool/main/g/gnome-media/gnome-media_2.10.2-1.diff.gz
gnome-media_2.10.2-1.dsc
to pool/main/g/gnome-media/gnome-media_2.10.2-1.dsc
gnome-media_2.10.2-1_i386.deb
to pool/main/g/gnome-media/gnome-media_2.10.2-1_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 308536 at bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Gustavo Noronha Silva <kov at debian.org> (supplier of updated gnome-media package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster at debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Tue, 25 Oct 2005 10:27:52 -0200
Source: gnome-media
Binary: gnome-media
Architecture: source i386
Version: 2.10.2-1
Distribution: unstable
Urgency: high
Maintainer: Debian GNOME Team <pkg-gnome-maintainers at lists.alioth.debian.org>
Changed-By: Gustavo Noronha Silva <kov at debian.org>
Description:
gnome-media - The GNOME Media Utilities
Closes: 268380 270649 305682 308536 316325
Changes:
gnome-media (2.10.2-1) unstable; urgency=high
.
[ Loic Minier ]
* Set maintainer to the pkg-gnome group.
* Add CDBS' utils rule.
.
[ Sjoerd Simons ]
* Add depend on gstreamer0.8-cdparanoia (Closes: #316325)
* Acknowledge NMU's (Closes: #270649, #308536, #268380, #305682)
.
[ Josselin Mouette ]
* Depend on ${misc:Depends} (high urgency fix).
Files:
8dbf1cf30da4c26f1ce8fd96f3383100 2008 gnome optional gnome-media_2.10.2-1.dsc
400a6fe4e7bba8215940ea94dd746cc9 4415259 gnome optional gnome-media_2.10.2.orig.tar.gz
19c8c69bdd161d01a7cf8b276f39a50e 7815 gnome optional gnome-media_2.10.2-1.diff.gz
36680fa6ed1e52b022599fe48d4b71a5 2784236 gnome optional gnome-media_2.10.2-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDXkQZt1anjIgqbEsRAj7LAJ4y/HfeLyNtuVj6smW/C6spz51AEACglZqJ
yOts0M12/WlxdIdNU5fpgyo=
=eBQt
-----END PGP SIGNATURE-----
More information about the Pkg-gnome-maintainers
mailing list