Bug#334450: Review of proposed stable changes

[Loic Minier]

        Hi,

On Tue, Oct 25, 2005, Martin Schulze wrote:
> That should be followed by dpkg-source -b, of course.

 Ok, I didn't knew about that, and it offered a shorter debdiff at the
 end indeed.  I did:

dpkg-source -x libgnomeprint_2.8.2-1.dsc
cd libgnomeprint-2.8.2 && patch -p1 < libgnomeprint_2.8.2-1.1.diff && cd -
dpkg-source -b libgnomeprint-2.8.2
interdiff -z -p1 libgnomeprint_2.8.2-1.diff.gz libgnomeprint_2.8.2-1.2.diff.gz > ~/libgnomeprint_2.8.2-1.2.diff

cd libgnomeprint-2.8.2 && dpkg-buildpackage -rfakeroot -us -uc && cd -
debdiff libgnomeprint-2.8.2-1.dsc libgnomeprint-2.8.2-1.2.dsc

 I attach the updated debdiff and interdiff (interdiff is identical).

   Bye,
-- 
Loïc Minier <lool at dooz.org>
-------------- next part --------------
diff -u libgnomeprint-2.8.2/debian/changelog libgnomeprint-2.8.2/debian/changelog
--- libgnomeprint-2.8.2/debian/changelog
+++ libgnomeprint-2.8.2/debian/changelog
@@ -1,3 +1,11 @@
+libgnomeprint (2.8.2-1.2) stable; urgency=low
+
+  * Non-maintainer upload tagetted at stable-proposed-updates.
+  * Fix calling of custom print commands.  popen() was called with an invalid
+    "b" flag. (Closes: #334450) [debian/patches/64_popen_without_b_flag.patch]
+
+ -- Loic Minier <lool at dooz.org>  Tue, 25 Oct 2005 13:16:24 +0200
+
 libgnomeprint (2.8.2-1) unstable; urgency=medium
  
   * New upstream release
only in patch2:
unchanged:
--- libgnomeprint-2.8.2.orig/debian/patches/64_popen_without_b_flag.patch
+++ libgnomeprint-2.8.2/debian/patches/64_popen_without_b_flag.patch
@@ -0,0 +1,12 @@
+diff -urN libgnomeprint-2.8.2.orig/libgnomeprint/transports/gp-transport-custom.c libgnomeprint-2.8.2/libgnomeprint/transports/gp-transport-custom.c
+--- libgnomeprint-2.8.2.orig/libgnomeprint/transports/gp-transport-custom.c	2004-12-03 19:25:09.000000000 +0100
++++ libgnomeprint-2.8.2/libgnomeprint/transports/gp-transport-custom.c	2005-10-25 12:41:38.000000000 +0200
+@@ -146,7 +146,7 @@
+ 		command = g_strdup ("lpr");
+ 	}
+ 
+-	tcustom->pipe = popen (command, "wb");
++	tcustom->pipe = popen (command, "w");
+ 
+ 	if (tcustom->pipe == NULL) {
+ 		g_warning ("Opening '%s' for output failed", command);
-------------- next part --------------
diff -u libgnomeprint-2.8.2/debian/changelog libgnomeprint-2.8.2/debian/changelog
--- libgnomeprint-2.8.2/debian/changelog
+++ libgnomeprint-2.8.2/debian/changelog
@@ -1,3 +1,11 @@
+libgnomeprint (2.8.2-1.2) stable; urgency=low
+
+  * Non-maintainer upload tagetted at stable-proposed-updates.
+  * Fix calling of custom print commands.  popen() was called with an invalid
+    "b" flag. (Closes: #334450) [debian/patches/64_popen_without_b_flag.patch]
+
+ -- Loic Minier <lool at dooz.org>  Tue, 25 Oct 2005 13:16:24 +0200
+
 libgnomeprint (2.8.2-1) unstable; urgency=medium
  
   * New upstream release
only in patch2:
unchanged:
--- libgnomeprint-2.8.2.orig/debian/patches/64_popen_without_b_flag.patch
+++ libgnomeprint-2.8.2/debian/patches/64_popen_without_b_flag.patch
@@ -0,0 +1,12 @@
+diff -urN libgnomeprint-2.8.2.orig/libgnomeprint/transports/gp-transport-custom.c libgnomeprint-2.8.2/libgnomeprint/transports/gp-transport-custom.c
+--- libgnomeprint-2.8.2.orig/libgnomeprint/transports/gp-transport-custom.c	2004-12-03 19:25:09.000000000 +0100
++++ libgnomeprint-2.8.2/libgnomeprint/transports/gp-transport-custom.c	2005-10-25 12:41:38.000000000 +0200
+@@ -146,7 +146,7 @@
+ 		command = g_strdup ("lpr");
+ 	}
+ 
+-	tcustom->pipe = popen (command, "wb");
++	tcustom->pipe = popen (command, "w");
+ 
+ 	if (tcustom->pipe == NULL) {
+ 		g_warning ("Opening '%s' for output failed", command);