Bug#288163: marked as done (eog: incorrectly creates threads when loading images)

Debian Bug Tracking System owner at bugs.debian.org
Thu Sep 1 21:48:19 UTC 2005


Your message dated Thu, 01 Sep 2005 14:32:04 -0700
with message-id <E1EAwfE-0005zx-00 at spohr.debian.org>
and subject line Bug#288163: fixed in eog 2.10.2-2
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 2 Jan 2005 02:34:59 +0000
>From john at nixnuts.net Sat Jan 01 18:34:59 2005
Return-path: <john at nixnuts.net>
Received: from ms-smtp-03.texas.rr.com (ms-smtp-03-eri0.texas.rr.com) [24.93.47.42] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1Ckva6-0002RP-00; Sat, 01 Jan 2005 18:34:59 -0800
Received: from localhost.localdomain (cs662559-191.houston.rr.com [66.25.59.191])
	by ms-smtp-03-eri0.texas.rr.com (8.12.10/8.12.7) with ESMTP id j022Ys2b000533;
	Sat, 1 Jan 2005 20:34:56 -0600 (CST)
Message-Id: <200501020234.j022Ys2b000533 at ms-smtp-03-eri0.texas.rr.com>
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: John Lightsey <john at nixnuts.net>
To: Debian Bug Tracking System <submit at bugs.debian.org>
Subject: eog: incorrectly creates threads when loading images
X-Mailer: reportbug 3.5
Date: Sat, 01 Jan 2005 20:35:19 -0600
X-Virus-Scanned: Symantec AntiVirus Scan Engine
Delivered-To: submit at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Package: eog
Version: 2.8.2-0.1
Severity: important

When viewing a lenghty collection of photos this error invariably
comes up:

GThread-ERROR **: file gthread-posix.c: line 351 (): error 'Cannot
allocate memory' during 'pthread_create'
aborting...

A simple grep over the source tree shows the problem...

john at lightning:~/src/tmp/eog/eog-2.8.2$ grep -nR "g_thread" *
libeog/eog-image.c:258: if (!g_thread_supported ()) {
libeog/eog-image.c:259:         g_thread_init (NULL);
libeog/eog-image.c:272:         thread = g_thread_create
(create_thumbnails, NULL, TRUE, NULL);
libeog/eog-image.c:968:         priv->load_thread = g_thread_create
(real_image_load, img, TRUE, NULL);
shell/eog-window.c:840: data->thread = g_thread_create (save_image_list,
data, TRUE, NULL);
shell/eog-window.c:1112:        data->thread = g_thread_create
(save_as_image_list, data, TRUE, NULL);
shell/eog-window.c:1214:        data->thread = g_thread_create
(save_as_image_list, data, TRUE, NULL);
john at lightning:~/src/tmp/eog/eog-2.8.2$

g_thread_create takes (1) a function to run in the new thread, (2) data
for the function, (3) a boolean value specifying whether the thread is
joinable, (4) a return location for errors.

The resources consumed by threads that are created as joinable are not
freed until g_thread_join is called on those threads.  Obviously, EOG
cannot create joinable threads for each new image without calling
g_thread_join at some point.

By changing the two TRUE parameters in eog-image.c to FALSE I can make
it through a directory full of several hundred images without a crash.
I'm not certain whether the other threads should be created as
un-joinable or if they should be joined at some point.

Thanks for packaging up EOG and looking into this problem.

John

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.9-1-k7
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)

Versions of packages eog depends on:
ii  libart-2.0-2             2.3.16-6        Library of functions for 2D graphi
ii  libatk1.0-0              1.8.0-4         The ATK accessibility toolkit
ii  libbonobo2-0             2.8.0-4         Bonobo CORBA interfaces library
ii  libbonoboui2-0           2.8.0-2         The Bonobo UI library
ii  libc6                    2.3.2.ds1-20    GNU C Library: Shared libraries an
ii  libexif10                0.6.9-4         The EXIF library allows you to par
ii  libgconf2-4              2.8.1-4         GNOME configuration database syste
ii  libglade2-0              1:2.4.1-1       Library to load .glade files at ru
ii  libglib2.0-0             2.4.8-1         The GLib library of C routines
ii  libgnome2-0              2.8.0-6         The GNOME 2 library - runtime file
ii  libgnomecanvas2-0        2.8.0-1         A powerful object-oriented display
ii  libgnomeui-0             2.8.0-3         The GNOME 2 libraries (User Interf
ii  libgnomevfs2-0           2.8.3-7         The GNOME virtual file-system libr
ii  libgtk2.0-0              2.4.14-2        The GTK+ graphical user interface 
ii  libice6                  4.3.0.dfsg.1-10 Inter-Client Exchange library
ii  libjpeg62                6b-9            The Independent JPEG Group's JPEG 
ii  liborbit2                1:2.10.2-1.1    libraries for ORBit2 - a CORBA ORB
ii  libpango1.0-0            1.6.0-3         Layout and rendering of internatio
ii  libpopt0                 1.7-5           lib for parsing cmdline parameters
ii  libsm6                   4.3.0.dfsg.1-10 X Window System Session Management
ii  libx11-6                 4.3.0.dfsg.1-10 X Window System protocol client li
ii  libxml2                  2.6.11-5        GNOME XML library
ii  xlibs                    4.3.0.dfsg.1-10 X Keyboard Extension (XKB) configu
ii  zlib1g                   1:1.2.2-4       compression library - runtime

-- no debconf information

---------------------------------------
Received: (at 288163-close) by bugs.debian.org; 1 Sep 2005 21:41:00 +0000
>From katie at spohr.debian.org Thu Sep 01 14:41:00 2005
Return-path: <katie at spohr.debian.org>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
	id 1EAwfE-0005zx-00; Thu, 01 Sep 2005 14:32:04 -0700
From: guilherme.pastore at terra.com.br (Guilherme de S. Pastore)
To: 288163-close at bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#288163: fixed in eog 2.10.2-2
Message-Id: <E1EAwfE-0005zx-00 at spohr.debian.org>
Sender: Archive Administrator <katie at spohr.debian.org>
Date: Thu, 01 Sep 2005 14:32:04 -0700
Delivered-To: 288163-close at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 2

Source: eog
Source-Version: 2.10.2-2

We believe that the bug you reported is fixed in the latest version of
eog, which is due to be installed in the Debian FTP archive:

eog_2.10.2-2.diff.gz
  to pool/main/e/eog/eog_2.10.2-2.diff.gz
eog_2.10.2-2.dsc
  to pool/main/e/eog/eog_2.10.2-2.dsc
eog_2.10.2-2_i386.deb
  to pool/main/e/eog/eog_2.10.2-2_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 288163 at bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guilherme de S. Pastore <guilherme.pastore at terra.com.br> (supplier of updated eog package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster at debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 10 Aug 2005 19:46:22 -0300
Source: eog
Binary: eog
Architecture: source i386
Version: 2.10.2-2
Distribution: unstable
Urgency: low
Maintainer: Guilherme de S. Pastore <guilherme.pastore at terra.com.br>
Changed-By: Guilherme de S. Pastore <guilherme.pastore at terra.com.br>
Description: 
 eog        - Eye of Gnome graphics viewer program
Closes: 287980 288163
Changes: 
 eog (2.10.2-2) unstable; urgency=low
 .
   * debian/patches/00_overwrite_error.diff:
   - apply patch from Gustavo Noronha Silva <kov at debian.org>
     to fix the error message displayed when overwriting a file.
     Thanks! (Closes: #287980)
   * debian/patches/01_threads.diff:
   - don't create threads as joinable if we're not going to join
     them, otherwise we end up with huge memory usage and even
     crashes (Closes: #288163)
   * debian/eog-collection-view.1:
   - removed, there's only one binary that handles this on the UI now
   * debian/control.in:
   - updated my e-mail address
Files: 
 b1077813802f984e352180124fe96cb2 1844 gnome optional eog_2.10.2-2.dsc
 97f23be0a8c2f7b3846b809102d6fc96 10289 gnome optional eog_2.10.2-2.diff.gz
 8fcf7c37cbf07e073e9cc44e78f863ae 618406 gnome optional eog_2.10.2-2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDF3GZt1anjIgqbEsRAk4aAJ9k7F1zGDqZ5SIhhty3yZFJOX23OwCgiuzD
+CchEbe4As4W5UQAOEIPmiI=
=8a9I
-----END PGP SIGNATURE-----





More information about the Pkg-gnome-maintainers mailing list