Bug#362823: tsclient: Underscore character in configuration profile filename is shown as a shortcut in drop down list

[Andreas Schaefer]

Package: tsclient
Version: 0.140-2
Severity: normal

In tsclient you can save current settings within a .rdp file.

If you use an underscore in the filename the drop down list
later on will interpret the underscore as the shortcut indicator and
will make the following character a shortcut. So you cannot
select the config file from the option menu (drop down list) 
anymore - because of the filename mismatch from the drop down list.

Example: the file "sv_master.rdp" gets displayed as "svmaster.rdp"
         with the "m" char marked as the shortcut (underlined).

a screenshot can be found at:

http://netra-t1-105.s-zone.org/_unsorted/tsclient-shortcut-bug.png

Even when saving the file with two underscores "sv__master.rdp"
as a workaround will not work because of the filename mismatch 
when selecting the item from the option menu (drop down list).

The real solution would be to disable shortcut processing for the
GTK widget by using gtk_menu_item_new_with_label instead of
gtk_menu_item_new_with_mnemonic.

for file src/connect.c in function "on_btnSaveAs_clicked" at line around 1463:
...
        GtkWidget *opt = lookup_widget (main_window, "optProfileLauncher");
	lastdelim += strlen (home) + 1;
//	mi = gtk_menu_item_new_with_mnemonic (lastdelim);
	mi = gtk_menu_item_new_with_label (lastdelim);
...


for file src/rdpfile.c in function "rdp_load_profile_launcher" at line around 946:
...
     name = g_strdup (lptr->data);
//     mi = gtk_menu_item_new_with_mnemonic (name);
     mi = gtk_menu_item_new_with_label (name);
     g_signal_connect (G_OBJECT (mi), "activate", G_CALLBACK (tsc_quick_pick_activate), name);
...


Greetings
Andreas

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.15
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages tsclient depends on:
ii  libatk1.0-0                   1.11.3-1   The ATK accessibility toolkit
ii  libbonoboui2-0                2.14.0-1   The Bonobo UI library
ii  libc6                         2.3.6-3    GNU C Library: Shared libraries an
ii  libglib2.0-0                  2.10.1-2   The GLib library of C routines
ii  libgnome2-0                   2.14.0-2   The GNOME 2 library - runtime file
ii  libgnomeui-0                  2.14.0-1   The GNOME 2 libraries (User Interf
ii  libgtk2.0-0                   2.8.16-1   The GTK+ graphical user interface 
ii  libpanel-applet2-0            2.12.3-1   library for GNOME 2 panel applets
ii  rdesktop                      1.4.1-1.1  RDP client for Windows NT/2000 Ter

tsclient recommends no packages.

-- no debconf information