Bug#381509: metacity: Please apply the double-click-menu-button-to-close patch

Adalbert Dawid dawid at rinux.net
Sat Aug 5 13:02:04 UTC 2006


Am Samstag, den 05.08.2006, 03:29 +0200 schrieb Josselin Mouette: 
> The patch is harmless as the so-called "feature" is disabled by default.
> However there isn't even a schema for the GConf key. I don't think it is
> appropriate to use a key that doesn't have a schema.

I added an appropriate schema to the source of metacity (version
2.14.5-1 from etch). The patch is appended below. As I'm not a gnome
developer nor a debian developer (not even a C programmer), I'm not sure
whether you will like this patch or not. But at least, it provides the
needed schema and works for me (when applied in connection with Thomas
Thurman's patch).
If you don't like the patch for any reason, please give me an advice
what should be done better.

Adalbert


diff -rup src.orig/metacity.schemas src/metacity.schemas
--- src.orig/metacity.schemas   2006-08-05 14:43:04.000000000 +0200
+++ src/metacity.schemas        2006-08-05 14:44:24.000000000 +0200
@@ -9,6 +9,20 @@
     <!-- General preferences -->

     <schema>
+      <key>/schemas/apps/metacity/general/close_on_double_click_menu</key>
+      <applyto>/apps/metacity/general/close_on_double_click_menu</applyto>
+      <owner>metacity</owner>
+      <type>bool</type>
+      <default>false</default>
+      <locale name="C">
+         <short>Enables double clicking the menu button to close a window</short>
+         <long>
+           Double clicking on a window's menu button will close the window.
+         </long>
+      </locale>
+    </schema>
+
+    <schema>
       <key>/schemas/apps/metacity/general/mouse_button_modifier</key>
       <applyto>/apps/metacity/general/mouse_button_modifier</applyto>
       <owner>metacity</owner>
diff -rup src.orig/metacity.schemas.in src/metacity.schemas.in
--- src.orig/metacity.schemas.in        2006-08-05 14:43:04.000000000 +0200
+++ src/metacity.schemas.in     2006-08-05 14:43:38.000000000 +0200
@@ -9,6 +9,20 @@
     <!-- General preferences -->

     <schema>
+      <key>/schemas/apps/metacity/general/close_on_double_click_menu</key>
+      <applyto>/apps/metacity/general/close_on_double_click_menu</applyto>
+      <owner>metacity</owner>
+      <type>bool</type>
+      <default>false</default>
+      <locale name="C">
+         <short>Enables double clicking the menu button to close a window</short>
+         <long>
+           Double clicking on a window's menu button will close the window.
+         </long>
+      </locale>
+    </schema>
+
+    <schema>
       <key>/schemas/apps/metacity/general/mouse_button_modifier</key>
       <applyto>/apps/metacity/general/mouse_button_modifier</applyto>
       <owner>metacity</owner>






More information about the Pkg-gnome-maintainers mailing list