Bug#385063: python-gtk2: inconsistent use of tabs and spaces in indentation in pygtk.py and __init__.py

Sam Hocevar sam at zoy.org
Tue Aug 29 09:02:35 UTC 2006


On Mon, Aug 28, 2006, Miguel Angel Barcena Rodriguez wrote:

> inconsistent use of tabs and spaces in indentation in files:
> /usr/share/python-gtk-2.0/pygtk.py
> /usr/share/python-support/python-gtk2/gtk-2.0/gtk/__init__.py

   Many people are apparently ridiculing this bug report. Personally
I don't see why a publicly installed file should not have proper
indentation. If you don't see why it could be a problem, here is an
excerpt of /usr/share/python-gtk-2.0/pygtk.py with tab width set to 8
spaces:

        for filename in glob.glob(os.path.join(dir, _pygtk_dir_pat)):
            pathname = os.path.join(dir, filename)

            # skip non directories
            if not os.path.isdir(pathname):
                continue

            # skip empty directories
            if not os.listdir(pathname):
                continue

            if not versions.has_key(filename[-3:]):
                versions[filename[-3:]] = pathname

   Here is the same chunk with tab width set to 4:

        for filename in glob.glob(os.path.join(dir, _pygtk_dir_pat)):
            pathname = os.path.join(dir, filename)

            # skip non directories
            if not os.path.isdir(pathname):
                continue

            # skip empty directories
            if not os.listdir(pathname):
                continue

        if not versions.has_key(filename[-3:]):
                versions[filename[-3:]] = pathname

-- 
Sam.





More information about the Pkg-gnome-maintainers mailing list