Bug#396043: fixed in gnome-hearts 0.1.3-1

Torbj|rn Andersson d91tan at Update.UU.SE
Fri Dec 8 20:24:55 CET 2006


The reported bug may have been fixed, but gnome-hearts 0.1.3-1 still 
crashes for me on start-up, and I think I see why:

The load_card_styles() function in hearts.c assembles a hash table of all 
the available card styles, and then it calls

     g_hash_table_foreach(game_card_styles, card_style_add, NULL);

This NULL pointer is passed as the 'first_style' parameter to 
card_style_add(), where it's dereferenced, like this:

     if (*first_style == NULL)
         *first_style = g_string_new(value);

This, of course, causes a crash. So I'm wondering, shouldn't that 
"foreach" call be something like this instead?

     g_hash_table_foreach(game_card_styles, card_style_add, &first_style);

At least, that seems to fix things for me.

Torbjörn Andersson


More information about the Pkg-gnome-maintainers mailing list