Bug#369083: Error in the patch for the memory leak
Samuel Mimram
samuel.mimram at ens-lyon.org
Tue Jul 4 06:39:03 UTC 2006
reopen 369083
thanks
Hi,
I made a mistake in the patch I sent to you: the IPP_TAGs should
obviously be or-ed and not and-ed... I've checked, the version in
incoming contains this mistake. Here is an updated version of the patch.
Cheers,
Samuel.
-------------- next part --------------
--- libgnomecups-0.2.2.orig/libgnomecups/gnome-cups-request.c
+++ libgnomecups-0.2.2/libgnomecups/gnome-cups-request.c
@@ -469,18 +469,14 @@
int n_attributes,
char **attributes)
{
- ipp_attribute_t *attr;
- int i;
- attr = ippAddStrings (request,
- group,
- IPP_TAG_KEYWORD,
- "requested-attributes",
- n_attributes, NULL, NULL);
-
- for (i = 0; i < n_attributes; i++) {
- attr->values[i].string.text = gnome_cups_strdup (attributes[i]);
- }
+ ippAddStrings (request,
+ group,
+ IPP_TAG_KEYWORD | IPP_TAG_COPY,
+ "requested-attributes",
+ n_attributes,
+ NULL,
+ (const char**)attributes);
}
typedef struct
More information about the Pkg-gnome-maintainers
mailing list