Bug#368350: libgksuui1.0: Right click on the password entry should be disabled

[Jeremie Corbier]

Package: libgksuui1.0
Severity: normal
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


When asked to type in a password in gksu{,do}, if you right-click on the
password text entry, it opens a context menu which makes the entry lose
the focus (which is the normal behaviour so far).

The problem is, the password entry can't get the focus back and moreover when
launching, let's say, "gksudo gvim" in a term and if you try to enter the
password after what I have explained above, the input is handled by the term
itself and thus your password is "world readable" after the validation.

As the options proposed by the menu are not relevant in this context, I think
the menu should be disabled (see the attached patch).

- -- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.16.16
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFEcHKOFq2EwGQTI7ERAkBqAJ9bjyLGAO96ObCUOyu97IyCB/CARgCfUZLE
IOPKV8UmlpS7OUMNwx9eS1M=
=u+EC
-----END PGP SIGNATURE-----
-------------- next part --------------
--- libgksuui/gksuui-dialog.c	2005-07-20 22:11:15.000000000 +0200
+++ libgksuui/gksuui-dialog.c	2006-05-20 03:17:27.000000000 +0200
@@ -63,6 +63,12 @@
 {
 }
 
+gboolean
+dummy_button_press(GtkWidget *widget, GdkEventButton *event, gpointer user_data)
+{
+  return TRUE;
+}
+
 static void
 gksuui_dialog_init (GksuuiDialog *gksuui_dialog)
 {
@@ -155,6 +161,8 @@
   g_signal_connect_swapped (G_OBJECT(gksuui_dialog->entry), "activate",
 			    G_CALLBACK(gtk_button_clicked), 
 			    gksuui_dialog->ok_button);
+  g_signal_connect (G_OBJECT(gksuui_dialog->entry), "button-press-event",
+		    G_CALLBACK(dummy_button_press), NULL);
   gtk_entry_set_visibility(GTK_ENTRY(gksuui_dialog->entry), FALSE);
   gtk_entry_set_invisible_char(GTK_ENTRY(gksuui_dialog->entry), 0x25cf); 
   gtk_box_pack_start (GTK_BOX (hbox), gksuui_dialog->entry,