Bug#417150: FTBFS with GCC 4.3: missing #includes

[Martin Michlmayr]

Package: dasher
Version: 4.2.2-1
Usertags: ftbfs-gcc-4.3
Tags: patch

Your package fails to build with GCC 4.3.  Version 4.3 has not been
released yet but I'm building with a snapshot in order to find errors
and give people an advance warning.  In GCC 4.3, the C++ header
dependencies have been cleaned up.  The advantage of this is that
programs will compile faster.  The downside is that you actually
need to directly #include everything you use (but you really should
do this anyway, otherwise your program won't work with any compiler
other than GCC).  Some background of this can be found at
http://gcc.gnu.org/PR28080

You can reproduce this problem with gcc-snapshot from unstable.

> Automatic build of dasher_4.2.2-1 on em64t by sbuild/amd64 0.53
...
> g++ -DHAVE_CONFIG_H -I. -I. -I../../..     -g -Wall -O2 -Wall -Wno-non-virtual-dtor -c -o DictLanguageModel.o DictLanguageModel.cpp
> DictLanguageModel.cpp: In member function 'Dasher::CDictLanguageModel::CDictnode* Dasher::CDictLanguageModel::AddSymbolToNode(Dasher::CDictLanguageModel::CDictnode*, Dasher::symbol, int*)':
> DictLanguageModel.cpp:69: error: 'USHRT_MAX' was not declared in this scope
> make[5]: *** [DictLanguageModel.o] Error 1
> make[5]: Leaving directory `/build/tbm/dasher-4.2.2/Src/DasherCore/LanguageModelling'

--- Src/DasherCore/LanguageModelling/DictLanguageModel.cpp~	2007-04-01 17:11:43.000000000 +0000
+++ Src/DasherCore/LanguageModelling/DictLanguageModel.cpp	2007-04-01 17:11:49.000000000 +0000
@@ -9,6 +9,7 @@
 #include "../../Common/Common.h"
 #include "DictLanguageModel.h"
 
+#include <climits>
 #include <math.h>
 #include <stack>
 #include <iostream>
--- Src/DasherCore/LanguageModelling/WordLanguageModel.h~	2007-04-01 17:14:52.000000000 +0000
+++ Src/DasherCore/LanguageModelling/WordLanguageModel.h	2007-04-01 17:27:49.000000000 +0000
@@ -9,6 +9,8 @@
 #ifndef __WordLanguageModel_h__
 #define __WordLanguageModel_h__
 
+#include <cstdlib>
+
 #include "../../Common/NoClones.h"
 #include "../../Common/Allocators/PooledAlloc.h"
 #include "LanguageModel.h"
--- Src/DasherCore/Alphabet/Alphabet.h~	2007-04-01 17:15:45.000000000 +0000
+++ Src/DasherCore/Alphabet/Alphabet.h	2007-04-01 17:15:52.000000000 +0000
@@ -15,6 +15,7 @@
 #include "../DasherTypes.h"
 #include "GroupInfo.h"
 
+#include <cstdlib>
 #include <vector>
 #include "AlphabetMap.h"
 #include "AlphIO.h"
--- Src/DasherCore/DasherModel.h~	2007-04-01 17:17:33.000000000 +0000
+++ Src/DasherCore/DasherModel.h	2007-04-01 17:17:40.000000000 +0000
@@ -25,6 +25,7 @@
 #include "ConversionManagerFactory.h"
 #endif
 
+#include <climits>
 #include <math.h>
 #include "DasherTypes.h"
 #include "FrameRate.h"
--- Src/DasherCore/UserLocation.h~	2007-04-01 17:18:42.000000000 +0000
+++ Src/DasherCore/UserLocation.h	2007-04-01 17:18:49.000000000 +0000
@@ -11,6 +11,7 @@
 #define __USER_LOCATION_H__
 
 #include "FileLogger.h"
+#include <cstdlib>
 #include <string>
 #include <time.h>
 #include "TimeSpan.h"
--- Src/DasherCore/XMLUtil.h~	2007-04-01 17:22:23.000000000 +0000
+++ Src/DasherCore/XMLUtil.h	2007-04-01 17:22:29.000000000 +0000
@@ -9,6 +9,7 @@
 #ifndef __XML_UTIL_H__
 #define __XML_UTIL_H__
 
+#include <cstdlib>
 #include <string>
 #include <vector>
 #include <stdio.h>
--- Src/Gtk2/Canvas.h~	2007-04-01 17:24:01.000000000 +0000
+++ Src/Gtk2/Canvas.h	2007-04-01 17:26:18.000000000 +0000
@@ -1,6 +1,8 @@
 #ifndef __canvas_h__
 #define __canvas_h__
 
+#include <cstdlib>
+
 #include "../DasherCore/DasherScreen.h"
 #include "../DasherCore/DasherTypes.h"
 #include "../DasherCore/CustomColours.h"
@@ -9,6 +11,7 @@
 #include <gdk/gdk.h>
 #include "PangoCache.h"
 
+#include <cstdlib>
 #include <iostream>
 
 #if WITH_CAIRO


-- 
Martin Michlmayr
http://www.cyrius.com/