[Bug 56070] Can't click button after setting it sensitive.

[gtk+ (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=56070

  gtk+ | gtk | Ver: 2.6.x





------- Comment #68 from Ed Catmur  2007-01-06 23:47 UTC -------
(In reply to comment #65)
> Some comments:
> 
> - I believe you are leaking the synthesized event.
Oops.

> - I don't think we need the mode argument, since all callers
>   are passing GDK_CROSSING_SYNTHESIZED
Yes.

> - I think gdk_widget_synthesize_crossing_for_foo should be 
>   public api, so that 3rd party no-window widgets can enjoy
>   the same fix as GtkButton.
Yes, that makes sense.  This allows gtk_widget_synthesize_crossing_event to be
made static and simplified, as you have done.

> - When making those functions public, it would be nicer IMO
>   to pull the GDK_WIDGET_SYNTH_CROSSING() check into the functions.
Yes, if it's external API.

> Here is an updated patch that addresses these points. 
> Do you agree to make those functions public ?
Yes, good idea.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email