[Bug 123383] Add "Rate song" menu item/keybinding

[rhythmbox (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=123383

  rhythmbox | User Interface | Ver: unspecified


Jonathan Matthew changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80876|none                        |reviewed
               Flag|                            |




------- Comment #11 from Jonathan Matthew  2007-01-28 22:13 UTC -------
I don't think it's a great idea to add a whole new menu for this.  I'm not
quite sure where it should go instead - maybe a sub-menu in the Control menu?

I don't really like the idea of using ctrl-left and ctrl-right to modify
ratings.  Do we really need app-wide shortcuts for this?  The problem I have
here is that unless the rating column is displayed and the playing song is
visible in the track list, there's no feedback to the user indicating that
anything actually happened.

Being able to modify the rating using keys when a rating widget has focus would
be good, though.

Some code style issues:
- rb_shell_player_rating_cb is not a callback, so it shouldn't be named like
one
- don't declare variables in the middle of a code block (declaration of 'value'
in rb_shell_player_rating_cb)
- spaces before function arguments ("function (args)", not "function(args)")
- it looks like you're inconsistently using spaces and tabs for indentation
- there's not much point clipping score to 0.0 <= score <= 5.0 and then doing
'g_return_if_fail (score >= 0 && score <= 5);'


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email