Bug#416634: ekiga: Crashes on amd64 when accepting an incoming call

[Steve Langasek]

On Sat, Mar 31, 2007 at 10:44:57AM +0200, Guus Sliepen wrote:
> Actually, after doing some stuff with a 32 bits ekiga binary, I somehow
> changed the configuration in such a way (probably left it in
> "videophone" mode) that the 64 bits binary does crash on startup, again
> due to the same problem as in #415731.

Hmm, can you send an example gconf tree I might use to reproduce this here?

> > +  va_end (args);
> > +
> > +  va_start (args, format);

> Yes, this is a fix, however I think the problem was caused by
> vsnprintf() being called twice with exactly the same arguments. Probably
> a cut&paste bug. The buffer from the first vsnprintf() is never used, so
> a better fix is just to remove that first call to vsnprintf(). I also
> found an instance of va_start() being called without a matching
> va_end(). Patch attached.

Yes, you're absolutely right, the first vsnprintf call is totally wasted and
can be safely discarded.  Your patch is far the better.

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon at debian.org                                   http://www.debian.org/