GTK 2.10 and Mac menu bar patch (Solved)

[Mathias Brodala]

Hi.

Loïc Minier, 09.05.2007 10:19:
> On Tue, May 08, 2007, Mathias Brodala wrote:
>> I’d like to apply the Mac menubar patch[0] to the GTK libs, but am puzzled as to
>> how to do that. If I place the patch directly in the debian/patches directory,
>> the directfb build fails:
>>
>>> gcc -DG_DISABLE_DEPRECATED -Wall -g -O2 -o .libs/gtk-query-immodules-2.0 queryimmodules.o  ./.libs/libgtk-directfb-2.0.so ../gdk-pixbuf/.libs/libgdk_pixbuf-2.0.so ../gdk/.libs/libgdk-directfb-2.0.so
>>> ./.libs/libgtk-directfb-2.0.so: undefined reference to `gdk_x11_drawable_get_xid'
>>> ./.libs/libgtk-directfb-2.0.so: undefined reference to `XInternAtom'
>>> ./.libs/libgtk-directfb-2.0.so: undefined reference to `XChangeProperty'
>>> ./.libs/libgtk-directfb-2.0.so: undefined reference to `gdk_display'
>>> collect2: ld returned 1 exit status
>> The debian/rules file suggests that the directfb flavor can be disabled but the
>> overall build also fails then.
> 
>  Either change your patch to add "#ifdef GDK_WINDOWING_X11",

Encapsulating every hunk with "#ifdef GDK_WINDOWING_X11 … #endif" worked like a
charm. Thank you very much!

>  or try
>  fixing the build process to not build the directfb packages (probably
>  commenting them out of debian/control is enough),

The file is pretty hard to understand if you’re not that experienced; removing
directfb from $(FLAVORS) and $(CHECK_FLAVORS) only resulted in problems.

> or try changing the
>  build process to permit adding flavor specific patches.

I guess for this I would have to study the New Maintainers Guide.


Thanks and Regards, Mathias

-- 
debian/rules

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20070509/1d9346d8/signature.pgp