Bug#366253: Debian bug followup (Re: bug 366253)

[Emil Nowak]

On 17-10-2007 Sven Arvidsson wrote:

> The initial part of your bug report, "does not set the WM_TRANSIENT_FOR
> hint for windows", seems to work for me with GTK+ 2.12, and possibly
> earlier. So if you don't disagree, I will close the bug for this
> version.
> 
> As for not generating warnings, I'm not sure if this is by design or
> not. I think it would be best to ask the gtk+ developers about this, on
> the mailing list or on irc.
When I read it now It seems to obvious to ask on mailing list. 
If you pass NULL value as "parent" variable to this expression:
g_return_if_fail (parent == NULL);
if will evaluate to
g_return_if_fail (NULL == NULL); 
which is TRUE so it never fails. IMHO someone just made a typo here. Attached
patch fixes that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: transiet_check.patch
Type: text/x-patch
Size: 589 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20071017/d004f173/attachment.bin