Bug#477113: seahorse: ephy_window_get_active_embed implicitly converted to pointer

[dann frazier]

Package: seahorse
Version: 2.22.1-1
Severity: serious
Usertags: implicit-pointer-conversion

Our automated buildd log filter[1] detected a problem that is likely to
cause your package to segfault on architectures where the size of a
pointer is greater than the size of an integer, such as ia64 and amd64.

  Function `ephy_window_get_active_embed' implicitly converted to pointer at seahorse-extension.c:242

This is often due to a missing function prototype definition.
For more information, see [2].

Though it is guaranteed that this codepath will cause a segfault on certain
architectures, it is not guaranteed that this codepath would ever be executed
(e.g., if the returned pointer is never dereferenced). However, this bug
does prevent the ia64 buildd from successfully building this package, resulting
in a practical FTBFS issue and warranting the serious severity.

Apparently, epiphany has changed its API, first renaming
ephy_window_get_active_embed to ephy_window_get_active_tab[3], then
removing the function altogether[4]. Since this change was external to
seahorse, it wasn't noticed until a recent binNMU.

[1] http://people.debian.org/~dannf/check-implicit-pointer-functions
[2] http://wiki.debian.org/ImplicitPointerConversions
[3] http://svn.gnome.org/viewvc/epiphany/trunk/src/ephy-window.h?r1=7582&r2=7584
[4] http://svn.gnome.org/viewvc/epiphany/trunk/src/ephy-window.h?r1=7584&r2=7693