Bug#433835: nautilus: No documentation on which volumen devices icons are shown and which filtered

Josselin Mouette joss at debian.org
Fri Jan 11 09:04:10 UTC 2008


Le vendredi 11 janvier 2008 à 03:11 +0100, Javier Fernández-Sanguino
Peña a écrit :
> Do you mean this?
> 
> gnome-vfs-2.20.1/libgnomevfs/gnome-vfs-hal-mounts.c:
> 
>     628         const char *fhs23_toplevel_mount_points[] = {
>     629                 "/",
>     630                 "/bin",

Yes.

> The way it is implemented, the exclusion list fails to exclude
> filesystems that are mounted under those that it hides (in my situation
> /home/mirrors under /home, which is excluded). Is this a bug?

It is intentional, but not optimal.

> Maybe it should be changed (line 694):
> 
>    if (strcmp (mount_point, fhs23_toplevel_mount_points[i]) == 0)
> 
> to
> 
>    if (strncmp (mount_point, fhs23_toplevel_mount_points[i],
> sizeof(fhs23_toplevel_mount_points[i])) == 0)
> 
> so that it would exclude both '/home/' and any filesystems mounted under
> '/home'? This is just an example, it should be more elaborate since the 
> above code can lead to false positives as it would also exclude the
> '/home_company' filesystem (which would not mounted underneath '/home'). It
> wouldn't be too difficult to implement a patch for this feature (hide a
> system volume and all volumes underneath it). Should I do it?

This is a good idea, but that needs better thought. Especially, volumes
under /media and /mnt must not be ignored.

The way I have dealt with it until now is to add commonly found
locations in 06_blacklist-directories.patch.

> You say that Nautilus only blacklists from a hardcoded list but, actually,
> reading that code I see it calls libhal_volume_should_ignore() to
> explicitly ignore volumes. It seems that if a volume has the property
> "volume.ignore" defined in HAL it is not presented. So it actually seems that
> the sysadmin could adjust the configuration files under /etc/hal/fdi to
> explicitly tell nautilus to ignore a volume.

Yes, both blacklists add together.

> > > Could this behaviour please be documented somewhere?
> > 
> > It could, but I???m not sure where to put it so that people interested in
> > it will find it.
> 
> It should be in Nautilus "Help" documentation (as the manpage is very brief).

Frankly I don’t think so. This is the user manual and should not talk
about such advanced settings.

> That's where I tried to look for it first. Other options would be  GNOME's
> System Admistrators Guide, maybe under the 'lockdown' section.  Since this is
> actually limiting what users "see" of the system underneath from their
> Desktops.

That would be a better option indeed. As it is a translated manual, I
also think it should be done upstream.

-- 
 .''`.
: :' :      We are debian.org. Lower your prices, surrender your code.
`. `'       We will add your hardware and software distinctiveness to
  `-        our own. Resistance is futile.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Ceci est une partie de message
	=?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=
Url : http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20080111/23368156/attachment-0001.pgp 


More information about the pkg-gnome-maintainers mailing list