Bug#487160: epiphany-gecko: Password manager doesn't remove passwords

[Mike Hommey]

Package: epiphany-gecko
Version: 2.22.2-3
Severity: normal
Tags: patch

When you go to the password manager (Edit > Personal Data > Passwords)
and remove an entry, while the entry is not displayed any more, it is
still in the password manager. Just close the window and come back, it's
still there.

This seems to be due to some mess in variable settings in
impl_remove_password.

I haven't tested the attached patch, but it should fix the issue.

Mike


-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.25-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages epiphany-gecko depends on:
ii  dbus                   1.2.1-2           simple interprocess messaging syst
ii  epiphany-browser-data  2.22.2-3          Data files for the GNOME web brows
ii  gnome-icon-theme       2.22.0-1          GNOME Desktop icon theme
ii  iso-codes              3.0-1             ISO language, territory, currency,
ii  libart-2.0-2           2.3.20-2          Library of functions for 2D graphi
ii  libatk1.0-0            1.22.0-1          The ATK accessibility toolkit
ii  libavahi-client3       0.6.22-5          Avahi client library
ii  libavahi-common3       0.6.22-5          Avahi common library
ii  libavahi-glib1         0.6.22-5          Avahi glib integration library
ii  libavahi-gobject0      0.6.22-5          Avahi GObject library
ii  libbonobo2-0           2.22.0-1          Bonobo CORBA interfaces library
ii  libbonoboui2-0         2.22.0-1          The Bonobo UI library
ii  libc6                  2.7-12            GNU C Library: Shared libraries
ii  libcairo2              1.6.4-6           The Cairo 2D vector graphics libra
ii  libdbus-1-3            1.2.1-2           simple interprocess messaging syst
ii  libdbus-glib-1-2       0.76-1            simple interprocess messaging syst
ii  libenchant1c2a         1.3.0-5.1         a wrapper library for various spel
ii  libfontconfig1         2.6.0-1           generic font configuration library
ii  libfreetype6           2.3.6-1           FreeType 2 font engine, shared lib
ii  libgcc1                1:4.3.1-2         GCC support library
ii  libgconf2-4            2.22.0-1          GNOME configuration database syste
ii  libglade2-0            1:2.6.2-1         library to load .glade files at ru
ii  libglib2.0-0           2.16.3-2          The GLib library of C routines
ii  libgnome-desktop-2     2.22.2-1          Utility library for loading .deskt
ii  libgnome2-0            2.20.1.1-1        The GNOME 2 library - runtime file
ii  libgnomecanvas2-0      2.20.1.1-1        A powerful object-oriented display
ii  libgnomeui-0           2.20.1.1-1        The GNOME 2 libraries (User Interf
ii  libgnomevfs2-0         1:2.22.0-4        GNOME Virtual File System (runtime
ii  libgtk2.0-0            2.12.10-2         The GTK+ graphical user interface 
ii  libice6                2:1.0.4-1         X11 Inter-Client Exchange library
ii  libnotify1 [libnotify1 0.4.4-3           sends desktop notifications to a n
ii  libnspr4-0d            4.7.1-3           NetScape Portable Runtime Library
ii  liborbit2              1:2.14.13-0.1     libraries for ORBit2 - a CORBA ORB
ii  libpango1.0-0          1.20.3-1          Layout and rendering of internatio
ii  libpixman-1-0          0.10.0-2          pixel-manipulation library for X a
ii  libpng12-0             1.2.27-1          PNG library - runtime
ii  libpopt0               1.14-3            lib for parsing cmdline parameters
ii  libsm6                 2:1.0.3-2         X11 Session Management library
ii  libstartup-notificatio 0.9-1             library for program launch feedbac
ii  libstdc++6             4.3.1-2           The GNU Standard C++ Library v3
ii  libx11-6               2:1.1.4-2         X11 client-side library
ii  libxcursor1            1:1.1.9-1         X cursor management library
ii  libxext6               2:1.0.4-1         X11 miscellaneous extension librar
ii  libxfixes3             1:4.0.3-2         X11 miscellaneous 'fixes' extensio
ii  libxi6                 2:1.1.3-1         X11 Input extension library
ii  libxinerama1           2:1.0.3-2         X11 Xinerama extension library
ii  libxml2                2.6.32.dfsg-2     GNOME XML library
ii  libxrandr2             2:1.2.2-2         X11 RandR extension library
ii  libxrender1            1:0.9.4-2         X Rendering Extension client libra
ii  libxslt1.1             1.1.24-1          XSLT processing library - runtime 
ii  python2.5              2.5.2-6           An interactive high-level object-o
ii  xulrunner-1.9          1.9~rc2-4         XUL + XPCOM application runner
ii  xulrunner-1.9-gnome-su 1.9~rc2-3         Support for GNOME in xulrunner app
ii  zlib1g                 1:1.2.3.3.dfsg-12 compression library - runtime

Versions of packages epiphany-gecko recommends:
ii  epiphany-extensions           2.22.2-1   Extensions for Epiphany web browse
ii  yelp                          2.22.1-3   Help browser for GNOME 2

-- no debconf information
-------------- next part --------------
--- mozilla-embed-single.cpp.orig	2008-06-19 23:08:56.314248061 +0200
+++ mozilla-embed-single.cpp	2008-06-19 23:12:17.530246398 +0200
@@ -1090,7 +1090,7 @@
 
         if (info->host)
           NS_CStringToUTF16 (nsCString(info->host),
-                            NS_CSTRING_ENCODING_UTF8, userName);
+                            NS_CSTRING_ENCODING_UTF8, host);
         else
           host.SetIsVoid (PR_TRUE);
 
@@ -1104,7 +1104,7 @@
           NS_CStringToUTF16 (nsCString(info->httpRealm),
                             NS_CSTRING_ENCODING_UTF8, httpRealm);
         else
-          userName.SetIsVoid (PR_TRUE);
+          httpRealm.SetIsVoid (PR_TRUE);
 
         if (info->password)
           NS_CStringToUTF16 (nsCString(info->password),