Bug#492283: epiphany-gecko: bugfix proposal

Vincent Caron v.caron at zerodeux.net
Tue Oct 21 14:49:38 UTC 2008


Package: epiphany-gecko
Version: 2.22.3-4+b1
Followup-For: Bug #492283


It looks like the header/footer setters are using a LITERAL() macro defined
in http://svn.gnome.org/viewvc/epiphany/branches/gnome-2-22/embed/mozilla/GeckoPrintService.cpp?revision=8330&view=markup
(together with SetPrinterName). Looking at the reference GTK+ embedding
code at http://mxr.mozilla.org/mozilla-central/source/widget/src/gtk2/nsPrintDialogGTK.cpp#430
one sees a different code. GTK+ stores string as UTF8, XPCOM as UTF16. The
typecast does not handle this conversion properly (or at all actually).

This one-line patch fixes the problem in my Lenny's epiphany-gecko:

--- embed/mozilla/GeckoPrintService.cpp.orig    2008-10-21 16:20:11.000000000 +0200
+++ embed/mozilla/GeckoPrintService.cpp 2008-10-21 16:23:34.000000000 +0200
@@ -62,7 +62,7 @@
 #define CONF_PRINT_PAGE_TITLE           "/apps/epiphany/dialogs/print_page_title"
 #define CONF_PRINT_PAGE_URL             "/apps/epiphany/dialogs/print_page_url"
 
-#define LITERAL(s) reinterpret_cast<const nsAString::char_type*>(NS_L(s))
+#define LITERAL(s) NS_ConvertUTF8toUTF16(s).get()
 
 /* From nsIDeviceContext.h */
 #define NS_ERROR_GFX_PRINTER_BASE (1) /* adjustable :-) */


-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.23.1 (PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages epiphany-gecko depends on:
ii  dbus-x11               1.2.1-3           simple interprocess messaging syst
ii  epiphany-browser-data  2.22.3-4          Data files for the GNOME web brows
ii  gnome-icon-theme       2.22.0-1          GNOME Desktop icon theme
ii  iso-codes              3.3-1             ISO language, territory, currency,
ii  libart-2.0-2           2.3.20-2          Library of functions for 2D graphi
ii  libatk1.0-0            1.22.0-1          The ATK accessibility toolkit
ii  libavahi-client3       0.6.22-3          Avahi client library
ii  libavahi-common3       0.6.22-3          Avahi common library
ii  libavahi-gobject0      0.6.22-3          Avahi GObject library
ii  libbonobo2-0           2.22.0-1          Bonobo CORBA interfaces library
ii  libbonoboui2-0         2.22.0-1          The Bonobo UI library
ii  libc6                  2.7-14            GNU C Library: Shared libraries
ii  libcairo2              1.6.4-6           The Cairo 2D vector graphics libra
ii  libdbus-1-3            1.2.1-3           simple interprocess messaging syst
ii  libdbus-glib-1-2       0.76-1            simple interprocess messaging syst
ii  libenchant1c2a         1.4.2-3.3         a wrapper library for various spel
ii  libfontconfig1         2.6.0-1           generic font configuration library
ii  libfreetype6           2.3.7-2           FreeType 2 font engine, shared lib
ii  libgcc1                1:4.3.2-1         GCC support library
ii  libgconf2-4            2.22.0-1          GNOME configuration database syste
ii  libglade2-0            1:2.6.2-1         library to load .glade files at ru
ii  libglib2.0-0           2.16.6-1          The GLib library of C routines
ii  libgnome-desktop-2     2.22.3-2          Utility library for loading .deskt
ii  libgnome2-0            2.20.1.1-1        The GNOME 2 library - runtime file
ii  libgnomecanvas2-0      2.20.1.1-1        A powerful object-oriented display
ii  libgnomeui-0           2.20.1.1-2        The GNOME 2 libraries (User Interf
ii  libgnomevfs2-0         1:2.22.0-5        GNOME Virtual File System (runtime
ii  libgtk2.0-0            2.12.11-3         The GTK+ graphical user interface 
ii  libice6                2:1.0.4-1         X11 Inter-Client Exchange library
ii  libnotify1 [libnotify1 0.4.4-3           sends desktop notifications to a n
ii  libnspr4-0d            4.7.1-4           NetScape Portable Runtime Library
ii  liborbit2              1:2.14.13-0.1     libraries for ORBit2 - a CORBA ORB
ii  libpango1.0-0          1.20.5-2          Layout and rendering of internatio
ii  libpixman-1-0          0.10.0-2          pixel-manipulation library for X a
ii  libpng12-0             1.2.27-2          PNG library - runtime
ii  libpopt0               1.14-4            lib for parsing cmdline parameters
ii  libsm6                 2:1.0.3-2         X11 Session Management library
ii  libstartup-notificatio 0.9-1             library for program launch feedbac
ii  libstdc++6             4.3.2-1           The GNU Standard C++ Library v3
ii  libx11-6               2:1.1.5-2         X11 client-side library
ii  libxcb-render-util0    0.2.1+git1-1      utility libraries for X C Binding 
ii  libxcb-render0         1.1-1.1           X C Binding, render extension
ii  libxcb1                1.1-1.1           X C Binding
ii  libxcursor1            1:1.1.9-1         X cursor management library
ii  libxext6               2:1.0.4-1         X11 miscellaneous extension librar
ii  libxfixes3             1:4.0.3-2         X11 miscellaneous 'fixes' extensio
ii  libxi6                 2:1.1.3-1         X11 Input extension library
ii  libxinerama1           2:1.0.3-2         X11 Xinerama extension library
ii  libxml2                2.6.32.dfsg-4     GNOME XML library
ii  libxrandr2             2:1.2.3-1         X11 RandR extension library
ii  libxrender1            1:0.9.4-2         X Rendering Extension client libra
ii  libxslt1.1             1.1.24-2          XSLT processing library - runtime 
ii  python2.5              2.5.2-11.1        An interactive high-level object-o
ii  xulrunner-1.9          1.9.0.3-1         XUL + XPCOM application runner
ii  xulrunner-1.9-gnome-su 1.9.0.3-1         Support for GNOME in xulrunner app
ii  zlib1g                 1:1.2.3.3.dfsg-12 compression library - runtime

Versions of packages epiphany-gecko recommends:
ii  epiphany-extensions           2.22.2-1   Extensions for Epiphany web browse
ii  yelp                          2.22.1-8   Help browser for GNOME 2

Versions of packages epiphany-gecko suggests:
pn  mozplugger                    <none>     (no description available)

-- no debconf information






More information about the pkg-gnome-maintainers mailing list