r20940 - in /packages/unstable/update-manager/debian: ./ patches/ pos/
Emilio Pozuelo Monfort
pochu27 at gmail.com
Sun Aug 16 15:57:14 UTC 2009
Hi Stephan,
I have a few comments about the update:
speijnik-guest at users.alioth.debian.org wrote:
> --- packages/unstable/update-manager/debian/changelog [utf-8] (original)
> +++ packages/unstable/update-manager/debian/changelog [utf-8] Sun Aug 16 09:01:59 2009
> @@ -1,15 +1,15 @@
> -update-manager (0.68.debian-8) UNRELEASED; urgency=low
> +update-manager (1:0.200.0~exp3) UNRELEASED; urgency=low
You don't need the epoch here.
> + * New upstream release. Closes: #515965, #529333, #480504, #449040,
> + #519191, #454686, #462188, #503584, #519320, #541584, #533994,
> + #415376.
It's a good practice to say what is fixed for each bug. E.g.
* No longer does foo. Closes: #123.
* Fixed foobar to work with baz. Closes: #124.
* ...
> + * Complete rework of update-manager.
> + * Automatic bug reporting via reportbug.
> + * Synaptic not needed anymore, replaced with python-apt.
> + * Somewhat experimental, please report all problems.
> + * NOT RELEASED YET.
You have UNRELEASED in the distribution, this is not needed :)
> + -- Stephan Peijnik <debian at sp.or.at> Sun, 16 Aug 2009 10:57:29 +0200
>
> update-manager (0.68.debian-7) unstable; urgency=low
>
>
> Modified: packages/unstable/update-manager/debian/compat
> URL: http://svn.debian.org/wsvn/pkg-gnome/packages/unstable/update-manager/debian/compat?rev=20940&op=diff
> ==============================================================================
> --- packages/unstable/update-manager/debian/compat [utf-8] (original)
> +++ packages/unstable/update-manager/debian/compat [utf-8] Sun Aug 16 09:01:59 2009
> @@ -1,1 +1,1 @@
> -4
> +5
>
> Modified: packages/unstable/update-manager/debian/control
> URL: http://svn.debian.org/wsvn/pkg-gnome/packages/unstable/update-manager/debian/control?rev=20940&op=diff
> ==============================================================================
> --- packages/unstable/update-manager/debian/control [utf-8] (original)
> +++ packages/unstable/update-manager/debian/control [utf-8] Sun Aug 16 09:01:59 2009
You should modify debian/control.in and update debian/control with 'fakeroot
debian/rules clean'. Otherwise you will loose your changes when debian/control
is updated from control.in.
> @@ -1,55 +1,70 @@
> Source: update-manager
> Section: gnome
> Priority: optional
> +XS-Python-Version: all
> Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers at lists.alioth.debian.org>
> -Uploaders: Thibaut Paumard <paumard at users.sourceforge.net>, Emilio Pozuelo Monfort <pochu at ubuntu.com>, Gustavo Noronha Silva <kov at debian.org>, Loic Minier <lool at dooz.org>
> -Build-Depends: gnome-pkg-tools (>= 0.12.3),
> - cdbs (>= 0.4.42),
> - debhelper (>= 5.0.37.2),
> - python-all-dev (>= 2.4),
> - python-all,
> - python-distutils-extra (>= 1.90),
> - python-support (>= 0.3),
> - python-apt (>= 0.7.2)
> -Build-Depends-Indep: libxml-parser-perl,
> - scrollkeeper,
> - intltool,
> - sharutils
> -Standards-Version: 3.7.3
> -XS-Python-Version: >= 2.4
> +Uploaders: Stephan Peijnik <debian at sp.or.at>,
> + Michael Vogt <mvo at debian.org>
> +Build-Depends: debhelper (>= 5.0.51),
> + python-central (>= 0.5.6),
> + python
> +Build-Depends-Indep: intltool,
> + python-distutils-extra (>= 1.90),
> + python-sphinx (>= 0.6.1),
> + python-gobject,
> + python-gtk2,
> + python-apt (>= 0.7.11.1),
> + python-dbus,
> + python-gconf,
> + python-newt,
> + lsb-release,
> + python-vte
> +Standards-Version: 3.8.2
> +Vcs-Svn: svn://svn.debian.org/pkg-gnome/packages/unstable/update-manager
> +Vcs-Browser: http://svn.debian.org/viewsvn/pkg-gnome/packages/unstale/update-manager
^^^^^^^
s/unstale/unstable/
> -Package: update-manager
> +Package: update-manager-core
> +Architecture: all
> +Section: admin
> +XB-Python-Version: ${python:Versions}
> +Depends: ${python:Depends},
> + ${misc:Depends},
> + lsb-release,
> + update-manager-gnome (= ${source:Version}),
update-manager-core depends on update-manager-gnome, and viceversa. I think
that's problematic. I'd remove the update-manager-core dependency, and let
update-manager-gnome (and other frontends when they are written) depend on the
backend, to break the dependency loop.
> + python-apt (>= 0.7.11.1),
> + gksu
> +Replaces: update-manager (<< 1:0.93.7)
> +Conflicts: update-manager (<< 1:0.93.7)
> +Description: manage release upgrades
> + This is the core of update-manager
The description could be a bit more concrete. I'd put a description of what
update-manager is and what it does in all the description, and after that I'd
put what each package contains or does.
> +Package: update-manager-apidoc
I'd name the package update-manager-doc, to follow common practice.
> +Architecture: any
Shouldn't this be all?
> +Section: doc
> +Depends: ${misc:Depends}
> +Suggests: libjs-jquery,
> + update-manager-core (= ${source:Version}),
> + update-manager-gnome (= ${source:Version})
> +Description: Update Manager API documentation
> + This package contains the API documentation for Update Manager. Please note
> + that this is only useful if you intend to work on Update Manager and does
> + not include any documentation targeteted at end-users.
s/targeteted/targeted/
> +Package: update-manager-gnome
> Architecture: all
> XB-Python-Version: ${python:Versions}
> +Depends: ${python:Depends},
> + ${misc:Depends},
> + update-manager-core (= ${source:Version}),
> + python-gconf,
> + python-dbus,
> + python-gtk2,
> + gksu,
> + python-gobject,
> + python-vte
> +Replaces: update-manager (<< 0.200.0~pre0)
> +Conflicts: update-manager (<< 0.200.0~pre0)
> +Suggests: update-notifier, software-properties-gtk
> +Description: GNOME application that manages apt updates
> + This is the GNOME/Gtk apt update manager. It checks for updates and lets the
> + user choose which to install.
>
> Modified: packages/unstable/update-manager/debian/copyright
> URL: http://svn.debian.org/wsvn/pkg-gnome/packages/unstable/update-manager/debian/copyright?rev=20940&op=diff
> ==============================================================================
> --- packages/unstable/update-manager/debian/copyright [utf-8] (original)
> +++ packages/unstable/update-manager/debian/copyright [utf-8] Sun Aug 16 09:01:59 2009
> @@ -1,61 +1,108 @@
> This package was debianized by Michiel Sikkes <michiel at eyesopened.nl> on
> Mon, 25 Oct 2004 21:49:07 +0200.
>
> -It was downloaded from http://ftp.ubuntu.com/ubuntu/pool/main/u/update-manager/
> +It was downloaded from http://alioth.debian.org/frs/?group_id=100374
>
> Upstream Authors:
> Michiel Sikkes <michiel at eyesopened.nl>
> Michael Vogt <mvo at debian.org>
> Martin Willemoes Hansen <mwh at sysrq.dk>
> + Stephan Peijnik <debian at sp.or.at>
Indentation? ;)
> Modified: packages/unstable/update-manager/debian/rules
> URL: http://svn.debian.org/wsvn/pkg-gnome/packages/unstable/update-manager/debian/rules?rev=20940&op=diff
> ==============================================================================
> --- packages/unstable/update-manager/debian/rules [utf-8] (original)
> +++ packages/unstable/update-manager/debian/rules [utf-8] Sun Aug 16 09:01:59 2009
> @@ -1,49 +1,65 @@
> #!/usr/bin/make -f
>
> -DEB_PYTHON_SYSTEM := pysupport
Why are you switching to pycentral when everybody is switching to pysupport?
> -include /usr/share/gnome-pkg-tools/1/rules/uploaders.mk
You're removing our team magic!
> Modified: packages/unstable/update-manager/debian/update-manager-core.install
> URL: http://svn.debian.org/wsvn/pkg-gnome/packages/unstable/update-manager/debian/update-manager-core.install?rev=20940&op=diff
> ==============================================================================
> --- packages/unstable/update-manager/debian/update-manager-core.install [utf-8] (original)
> +++ packages/unstable/update-manager/debian/update-manager-core.install [utf-8] Sun Aug 16 09:01:59 2009
> @@ -1,4 +1,20 @@
> debian/tmp/usr/share/locale
> -debian/tmp/usr/lib/python*/site-packages/UpdateManager/Core
> -debian/tmp/usr/lib/python*/site-packages/UpdateManager/fdsend.so
> -debian/tmp/usr/lib/python*/site-packages/UpdateManager/__init__.py
> +debian/tmp/usr/share/update-manager/bug_script
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/__init__.py
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/Application.py
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/Config.py
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/Exceptions.py
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/ThreadManager.py
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/Util/
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/Backend/__init__.py
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/Backend/loader.py
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/Backend/PythonApt.py
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/DistSpecific/__init__.py
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/DistSpecific/changelog.py
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/DistSpecific/loader.py
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/DistSpecific/Auto.py
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/Frontend/__init__.py
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/Frontend/loader.py
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/Frontend/GtkCommon/
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/DistSpecific/Debian/
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/DistSpecific/Ubuntu/
Maybe you should write a setup.py script upstream? ;)
> Added: packages/unstable/update-manager/debian/update-manager-text.install
> URL: http://svn.debian.org/wsvn/pkg-gnome/packages/unstable/update-manager/debian/update-manager-text.install?rev=20940&op=file
> ==============================================================================
> --- packages/unstable/update-manager/debian/update-manager-text.install (added)
> +++ packages/unstable/update-manager/debian/update-manager-text.install [utf-8] Sun Aug 16 09:01:59 2009
> @@ -1,0 +1,2 @@
> +debian/tmp/usr/bin/update-manager-text
> +debian/tmp/usr/lib/python*/*-packages/UpdateManager/Frontend/Newt.py
update-manager-text? That is not listed in debian/control
That's all for now, need to try the new update-manager next :)
Cheers,
Emilio
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20090816/47c525b6/attachment.pgp>
More information about the pkg-gnome-maintainers
mailing list