r20940 - in /packages/unstable/update-manager/debian: ./ patches/ pos/

[Emilio Pozuelo Monfort]

Stephan Peijnik wrote:
> Hi Emilio,
> 
> Comments inline.
> 
> On Sun, 2009-08-16 at 17:57 +0200, Emilio Pozuelo Monfort wrote:
>> speijnik-guest at users.alioth.debian.org wrote:
>>> --- packages/unstable/update-manager/debian/changelog [utf-8] (original)
>>> +++ packages/unstable/update-manager/debian/changelog [utf-8] Sun Aug 16 09:01:59 2009
>>> @@ -1,15 +1,15 @@
>>> -update-manager (0.68.debian-8) UNRELEASED; urgency=low
>>> +update-manager (1:0.200.0~exp3) UNRELEASED; urgency=low
>> You don't need the epoch here.
> 
> I added the epoch because old upstream used the epoch for the 0.1xx.x
> versions. I assumed this would make it easier for both Ubuntu and Debian
> to keep track of versions.
> Without the epoch Ubuntu is likely going to use 1:version, whilst Debian
> isn't using it.

OK, it's fine then.

>>> -Package: update-manager
>>> +Package: update-manager-core
>>> +Architecture: all
>>> +Section: admin
>>> +XB-Python-Version: ${python:Versions}
>>> +Depends: ${python:Depends}, 
>>> +	 ${misc:Depends}, 
>>> +	 lsb-release, 
>>> +	 update-manager-gnome (= ${source:Version}), 
>> update-manager-core depends on update-manager-gnome, and viceversa. I think
>> that's problematic. I'd remove the update-manager-core dependency, and let
>> update-manager-gnome (and other frontends when they are written) depend on the
>> backend, to break the dependency loop.
> 
> Ok, I'll break that. The reason I added the dependency on the frontend
> is because the core alone won't be of any use. Originally this was a
> dependency on update-manager-gnome | update-manager-text. See my comment
> about the -text frontend below.

$package-data or -common don't usually depend on $package, even if they are
useless without them. $package depends on $package-data though. It's the same here.

>>> Modified: packages/unstable/update-manager/debian/rules
>>> URL: http://svn.debian.org/wsvn/pkg-gnome/packages/unstable/update-manager/debian/rules?rev=20940&op=diff
>>> ==============================================================================
>>> --- packages/unstable/update-manager/debian/rules [utf-8] (original)
>>> +++ packages/unstable/update-manager/debian/rules [utf-8] Sun Aug 16 09:01:59 2009
>>> @@ -1,49 +1,65 @@
>>>  #!/usr/bin/make -f
>>>  
>>> -DEB_PYTHON_SYSTEM := pysupport
>> Why are you switching to pycentral when everybody is switching to pysupport?
> 
> Opps, I missed that. I didn't want to use pycentral.

You don't need to set DEB_PYTHON_SYSTEM, btw. That's for CDBS. You use
dh_pysupport, so you can remove this line.

>>> -include /usr/share/gnome-pkg-tools/1/rules/uploaders.mk
>> You're removing our team magic!
> 
> Is this really needed?

Yes. That's what autogenerates debian/control and expands @GNOME_TEAM at .
http://pkg-gnome.alioth.debian.org/packaging.html

>> That's all for now, need to try the new update-manager next :)
> 
> It should work quite well and ask you to report a bug when something
> breaks (read: uncaught exception). 

Will do!

Cheers,
Emilio

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20090816/e7a09caa/attachment.pgp>