Bug#558406: gnome-keyring-daemon doesn't work on GNU/kFreeBSD

[Emmanuel Bouthenot]

reopen 558406
thanks

Hi,

Sorry to reopen the bug, but the first patch was not the good one and
it doesn't fix the bug at all.

Attached is a patch which definitely fix this bug.

I'm also CC-ing the debian-bsd@ list. Even if the patch fix the bug,
i'm not really statisfied. I suspect a deeper problem on how socket
credentials should work on kFreeBSD.

from  egg/egg-unix-credentials.c

--8<----- line 100 ---------
#if defined(HAVE_CMSGCRED) || defined(LOCAL_CREDS)
    if (cmsg.hdr.cmsg_len < CMSG_LEN (sizeof *cred) ||
       cmsg.hdr.cmsg_type != SCM_CREDS) {
       	fprintf (stderr, "message from recvmsg() was not\n");
	return -1;
}
#endif

=> always return -1
------------------------>8--

If the previous test is disabled then if fails on:

--8<----- line 122 ---------
#elif defined(HAVE_CMSGCRED)
      cred = (struct cmsgcred *) CMSG_DATA (&cmsg.hdr);
      *pid = cred->cmcred_pid;
      *uid = cred->cmcred_euid;
#elif defined(LOCAL_CREDS)


=> uid is always 0, it should be the user id (eg. >= 1000)
------------------------>8--


The fact that the source code builds fine and
HAVE_CMSGCRED/LOCAL_CREDS are defined makes me feel that something is
weird.

I will be glad to get debian-bsd@ folks opinions on it.

Regards,

-- 
Emmanuel Bouthenot
  mail: kolter@{openics,debian}.org    gpg: 1024D/0x414EC36E
  xmpp: kolter at im.openics.org          irc: kolter@{freenode,oftc}

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_gkd_kfreebsd.diff
Type: text/x-diff
Size: 1881 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20091216/db62a50c/attachment-0001.diff>