Bug#562005: [alacarte] GUI behaviour of right item pane does not meet expectations

[Lars Kruse]

Package: alacarte
Version: 0.12.4-1
Severity: normal
Tags: patch

--- Please enter the report below this line. ---

Hi,

naming conventions for the following description:
- "item pane": right half of the window
- "menu pane": left part of the window

various GUI actions of alacarte don't work as expected:

1) drag and drop of an item from the item pane "into" a menu item of the item
pane

I expect the dragged item to be moved into the selected target menu, but the
item just gets moved to the position after the target.
The same operation works as expected, if the destination is on the "menu pane".


2) moving a separator item from the item pane "into" a menu item of the "menu
pane"

I expect, that this removes the dragged separator from the original menu and
creates a new separator in the destination. The GUI feedback also indicates
this: the separator disappears.
But the separator is not moved at all: clicking on the original menu (for
refresh) causes the separator to appear again. The destination menu does not
contain a new separator.


3) dragging an item from the item pane to another position in the item pane
(between two other items)

This works as expected, if the destination is _above_ the current position of
the dragged item. But if it is below, then the item gets moved one position
further down, than expected.


The attached patch fixes these three issues.
I am not sure, if I handled the "undo" log properly, but the rest of the code
should be fine.

thanks for your work,
Lars

--- System information. ---
Architecture: i386
Kernel:       Linux 2.6.30-2-686

Debian Release: squeeze/sid
  990 testing         localhost 

--- Package information. ---
Depends               (Version) | Installed
===============================-+-=============
python                 (>= 2.4) | 2.5.4-2
python-support      (>= 0.90.0) | 1.0.6
python-gtk2         (>= 2.13.0) | 2.16.0-1
python-gmenu       (>= 2.27.92) | 2.28.0.1-1
gnome-menus        (>= 2.27.92) | 2.28.0.1-1
python-gobject      (>= 2.15.1) | 2.20.0-1


Recommends       (Version) | Installed
==========================-+-===========
gnome-panel                | 2.28.0-3


Package's Suggests field is empty.


-- 

gpg key: https://systemausfall.org/schluessel/lars-devel.0.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: proper_gui_behaviour.patch
Type: text/x-patch
Size: 4289 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20091221/4170dc89/attachment-0001.bin>