Bug#396215: new patch (don't skip, don't leak)

[Neil Moore]

After reviewing the patch further a few issues with
15_uuid_mount.patch presented themselves:

1. The logic to skip non-existent UUID= (and now LABEL=) mounts is
   spurious---it only affects UID= mounts, while leaving intact
   entries with non-existent device nodes, dangling symlinks to device
   nodes, etc.

2. There is a memory leak introduced by 15_uuid_mount.patch: if the
   fstab entry is skipped, mount_entry, mount_entry->device_path,
   and mount_entry->mount_path all need to be freed.

Discussion with J. Mouette on #gnome-debian indicated that it would be
best to keep all the mount points, whether or not the device can be
found.  The attached patch (again, to be applied after
15_uuid_mounts.patch) does that, fixing both of the above problems.


A more long-term solution would involve comparing filesystems by
st_dev rather than device_path; but it is not clear to me how to make
such a change without editing the GnomeVFSUnixMount structure and
potentially breaking binary compatibility.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: gnome-vfs-fstab-label-symlink-v2.diff
Type: text/x-diff
Size: 2329 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20090115/07eb1b62/attachment.diff 
-------------- next part --------------


-- 
Neil Moore, neil at s-z.org, http://s-z.org/neil/