Bug#512018: vinagre is unable to save bookmarks

[Emilio Pozuelo Monfort]

Paul van Tilburg wrote:
> I think that initially (after a fresh install) Vinagre is unable to save
> bookmarks (and possibly also history, haven't tested that yet).  This is
> because it attempts to save under the directory ~/.local/share/vinagre.
> However if this directory doesn't exist, which is initially the case,
> it doesn't seem to create it.
> 
> For example, after attempting to save a connection as a bookmark I get:
> 
> ** (vinagre:25972): WARNING **: Error while saving bookmarks: Failed to
>   create file '/home/paul/.local/share/vinagre/vinagre.bookmarks.DYDYNU': No
>   such file or directory
> 
> and no bookmark can be seen in the UI.  Once I have performed
> "mkdir ~/.local/share/vinagre", the bookmark saving works.

I can't reproduce it yet, but I'm probably not making the right steps.

Anyway, I've looked at the code and the problem seems to be in
src/vinagre-bookmarks.c, line 536. For some reason, at that point
~/.local/share/vinagre wasn't created for you, and g_file_set_contents() doesn't
create parent folders, so it gives you the "No such file or directory error.",
and that's why making the directory before starting Vinagre fixes it for you.

The steps I've followed to try to reproduce this were:

- Remove ~/.local/share/vinagre
- Start vinagre
- Connect to localhost

By this point, ~/.local/share/vinagre already exists.

- Save the bookmark

The bookmark is correctly saved.

- Quit vinagre.

Are they correct?

I want to reproduce this if possible to try to see if there's another bug in the
code. If not, I think the solution would be to call g_mkdir_with_parents()
before g_file_set_contents().

Cheers,
Emilio

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: OpenPGP digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20090121/fee5f21c/attachment.pgp