Bug#439089: Reason for the error

[Bob Hauck]

I've identified two problems with ICA and tsclient.  One is this Error 
3, the other is that it knows that wfica is installed but fails to run 
it unless you create a symlink in a directory on the path.

Both bugs are located in src/support.c.  The first one is because when 
wfica is spawned the argv array is not built to it's liking.  There is 
code like this in several places:

sprintf (buffer, "-description %s", (char *)g_strescape(rdp->description));
c_argv[c_argc++] = g_strdup(buffer);

This puts both the switch and the parameter into the same argv element.  
Apparently wfica does not handle this correctly.  If they are split up 
into two argv[[] elements then the Error 3 is eliminated.

The other problem is because the code checks for the existence of 
/usr/lib/ICAClient/wfica but then just uses "wfica" as the name of the 
executable, assuming that it is on the path.  Which is very unlikely for 
/usr/lib/ICAClient!

The attached patch fixes both problems.  You should be able to apt-get 
source tsclient and drop it into the debian/patches directory.  After 
rebuilding with dpkg-buildpackge "it works for me" with our corporate 
Citrix server and at least in my brief testing doesn't seem to break 
anything else.

A hint:  The "computer" line can be filled in with a Citrix service 
name, for example to use MS Word on our Citrix sever, I can use 
"Microsoft Word - Citrix" as the computer name.


-- 
 -| Bob Hauck (Brother Nail Gun of The Short Path)
 -| http://www.haucks.org/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20_fix-bad-parameters.patch
Type: text/x-patch
Size: 2269 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20090716/7fe14af3/attachment-0003.bin>