Bug#530800: metacity ignores Initial state in WM_HINTS

[Benno]

Package: metacity
Version: 2.22.0-2

When you execute "xterm -iconic" in gnome with the metacity
window-manager of the given version running, the resulting xterm
window is not displayed in iconic state(minimized), but in
normal state. With the xprops tool however, you can see, that the
initial state of WM_HINTS property is "Iconic State".
I expect the window to show up in iconic state(minimized).
I found this bug using Debian GNU/Linux 5.0(lenny), kernel 2.6.28.4.
These are the commands I used:

$ xterm -iconic &
$ xprop
...
WM_HINTS(WM_HINTS):
                Client accepts input or input focus: True
                Initial state is Iconic State.
...


This bug seems to be fixed in the upstream release metacity-2.24.0.
I suggest using the following patch, which is taken from the
upstream release metacity-2.24.0:

--- metacity-2.22.0/src/core/window.c.org       2008-03-09 22:49:15.000000000 +0100
+++ metacity-2.22.0/src/core/window.c   2009-05-27 11:52:59.000000000 +0200
@@ -796,8 +796,11 @@
    * However, we shouldn't unminimize windows here when opening
    * a new display because that breaks passing _NET_WM_STATE_HIDDEN
    * between window managers when replacing them; see bug 358042.
+   *
+   * And we shouldn't unminimize windows if they were initially
+   * iconic.
    */
-  if (!display->display_opening)
+  if (!display->display_opening && !window->initially_iconic)
     unminimize_window_and_all_transient_parents (window);

   meta_error_trap_pop (display, FALSE); /* pop the XSync()-reducing trap */