Bug#558644: totem-pl-parser: missing versioned build-dep on libgtk2.0-dev

[Andres Salomon]

Package: totem-pl-parser
Version: 2.28.1-2
Severity: important

While building on lenny with all build-deps satisfied, I hit the
following error:

/bin/sh ../libtool  --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I..  -I.. -I../lib -I../plparse -DGNOMELOCALEDIR=\""/usr/share/locale"\"    -D_REENTRANT -pthread -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 -I/usr/include/pixman-1 -I/usr/include/libxml2 -I/usr/include/gmime-2.4     -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare   -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -I../lib -D_GNU_SOURCE -Wall  -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes   -Wnested-externs -Wpointer-arith        -Wcast-align -Wsign-compare     -fno-strict-aliasing    -g -O2 -g -Wall -O2 -c -o libtotem_plparser_la-totem-pl-parser-builtins.lo `test -f 'totem-pl-parser-builtins.c' || echo './'`totem-pl-parser-builtins.c
libtool: compile:  cc -DHAVE_CONFIG_H -I. -I.. -I.. -I../lib -I../plparse -DGNOMELOCALEDIR=\"/usr/share/locale\" -D_REENTRANT -pthread -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 -I/usr/include/pixman-1 -I/usr/include/libxml2 -I/usr/include/gmime-2.4 -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -I../lib -D_GNU_SOURCE -Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -fno-strict-aliasing -g -O2 -g -Wall -O2 -c totem-pl-parser-builtins.c  -fPIC -DPIC -o .libs/libtotem_plparser_la-totem-pl-parser-builtins.o
In file included from totem-pl-parser-builtins.c:4:
totem-pl-parser.h:359: error: expected declaration specifiers or ‘...’ before ‘GCancellable’
totem-pl-parser.h:360: error: expected declaration specifiers or ‘...’ before ‘GAsyncReadyCallback’
totem-pl-parser.h:363: error: expected declaration specifiers or ‘...’ before ‘GAsyncResult’
totem-pl-parser.h:373: error: expected declaration specifiers or ‘...’ before ‘GCancellable’
totem-pl-parser.h:374: error: expected declaration specifiers or ‘...’ before ‘GAsyncReadyCallback’
make[5]: *** [libtotem_plparser_la-totem-pl-parser-builtins.lo] Error 1
make[5]: Leaving directory `/totem/totem-pl-parser-2.28.1/plparse'


The following versions of build-deps were installed:

ii  libgtk2.0-0                          2.12.12-1~lenny1         The GTK+ graphical user interface library
ii  libgtk2.0-common                     2.12.12-1~lenny1         Common files for the GTK+ graphical user int
ii  libgtk2.0-dev                        2.12.12-1~lenny1         Development files for the GTK+ library
ii  libglib2.0-0                         2.22.2-2~bpo50+1         The GLib library of C routines
ii  libglib2.0-dev                       2.22.2-2~bpo50+1         Development files for the GLib library

I upgraded libgtk2.0-dev to version 2.18.3-1~bpo50+1, and the build
succeeded.  This is because totem-pl-parser.h only includes gtk.h
and glib.h, but not gio.h.  Gtk 2.18 includes gio.h, so the
GCancellable stuff gets declared; however, gtk 2.12 does not include it.

totem-pl-parser needs either a higher versioned build-dep on
libgtk2.0-dev, or the code should manually include gio/gio.h
(in which case using older versions of gtk would probably be fine).