Bug#544354: glib2.0: gio breaks on Lenny kernels when calling inotify_init1()

Josselin Mouette joss at debian.org
Tue Sep 1 10:01:54 UTC 2009


forwarded 544354 http://bugzilla.gnome.org/show_bug.cgi?id=593775
tag 544354 + pending
thanks

Le dimanche 30 août 2009 à 17:05 -0400, Michael Stone a écrit : 
> Recent upstream patches contained in glib2.0_2.20.4-1 cause the glib2.0-derived
> packages in squeeze to depend on kernel functionality -- inotify_init1() --
> that is not available in Lenny kernels. These packages should not depend on
> such functionality until squeeze is released.

Thanks for the investigation. It explains a lot of the issues that
appeared post-lenny with lenny kernels.

> Remediations
> ------------
> 
> A reasonable compromise might be to adjust the glib2.0 source code to call
> inotify_init whenever inotify_init1 fails, as in the following outline:
> 
> > inotify_instance_fd = -1;
> > 
> > #ifdef HAVE_INOTIFY_INIT1
> >   inotify_instance_fd = inotify_init1 (IN_CLOEXEC);
> > #endif
> > 
> > if (inotify_instance_fd < 0)
> >    inotify_instance_fd = inotify_init ();
> > 
> > if (inotify_instance_fd < 0)
> >    return FALSE;
> 
> (Thanks to dilinger at queued.mit.edu for the code.)

Looks like a reasonable solution. Applied in our SVN and forwarded
upstream.

Cheers,
-- 
 .''`.      Josselin Mouette
: :' :
`. `'   “I recommend you to learn English in hope that you in
  `-     future understand things”  -- Jörg Schilling
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Ceci est une partie de message num?riquement sign?e
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20090901/a4cbf223/attachment.pgp>


More information about the pkg-gnome-maintainers mailing list