Bug#564265: gnome-settings-daemon: xrandr ApplyConfiguration should default to "cancel"

[Maximiliano Curia]

Package: gnome-settings-daemon
Version: 2.28.1-1
Severity: normal

Hi,

The confirmation dialog presented to the user when the display size has been
changed defaults to "OK" and should default to "CANCEL", to give the user a
simple way to revert the change.

gnome-display-properties calls to org.gnome.SettingsDaemon.XRANDR_2.ApplyConfiguration
to change the desktop size, ask for user confirmation, etc. This call is managed by
./plugins/xrandr/gsd-xrandr-manager.c of gsd, thus this bug report.

The diff is quite small:

diff -Naru gnome-settings-daemon-2.28.1.orig/plugins/xrandr/gsd-xrandr-manager.c gnome-settings-daemon-2.28.1/plugins/xrandr/gsd-xrandr-manager.c
--- gnome-settings-daemon-2.28.1.orig/plugins/xrandr/gsd-xrandr-manager.c	2009-07-27 18:37:28.000000000 -0300
+++ gnome-settings-daemon-2.28.1/plugins/xrandr/gsd-xrandr-manager.c	2010-01-08 09:42:07.388661459 -0300
@@ -308,7 +308,7 @@
 
         gtk_dialog_add_button (GTK_DIALOG (timeout.dialog), _("_Restore Previous Configuration"), GTK_RESPONSE_CANCEL);
         gtk_dialog_add_button (GTK_DIALOG (timeout.dialog), _("_Keep This Configuration"), GTK_RESPONSE_ACCEPT);
-        gtk_dialog_set_default_response (GTK_DIALOG (timeout.dialog), GTK_RESPONSE_ACCEPT); /* ah, the optimism */
+        gtk_dialog_set_default_response (GTK_DIALOG (timeout.dialog), GTK_RESPONSE_CANCEL); /* its safer to be pesimist */
 
         g_signal_connect (timeout.dialog, "response",
                           G_CALLBACK (timeout_response_cb),

Thanks,

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-trunk-686 (SMP w/1 CPU core)
Locale: LANG=es_AR.UTF-8, LC_CTYPE=es_AR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages gnome-settings-daemon depends on:
ii  gconf2                      2.28.0-1     GNOME configuration database syste
ii  libc6                       2.10.2-3     Embedded GNU C Library: Shared lib
ii  libcairo2                   1.8.8-2      The Cairo 2D vector graphics libra
ii  libdbus-1-3                 1.2.16-2     simple interprocess messaging syst
ii  libdbus-glib-1-2            0.82-2       simple interprocess messaging syst
ii  libfontconfig1              2.8.0-2      generic font configuration library
ii  libgconf2-4                 2.28.0-1     GNOME configuration database syste
ii  libglib2.0-0                2.22.3-2     The GLib library of C routines
ii  libgnome-desktop-2-11       2.28.2-1     Utility library for loading .deskt
ii  libgnomekbd4                2.28.2-1     GNOME library to manage keyboard c
ii  libgstreamer-plugins-base0. 0.10.25-7    GStreamer libraries from the "base
ii  libgstreamer0.10-0          0.10.25-4+b1 Core GStreamer libraries and eleme
ii  libgtk2.0-0                 2.18.5-1     The GTK+ graphical user interface 
ii  libnotify1 [libnotify1-gtk2 0.4.5-1      sends desktop notifications to a n
ii  libx11-6                    2:1.3.2-1    X11 client-side library
ii  libxi6                      2:1.2.1-2    X11 Input extension library
ii  libxklavier15               4.0-2        X Keyboard Extension high-level AP
ii  libxxf86misc1               1:1.0.2-1    X11 XFree86 miscellaneous extensio

gnome-settings-daemon recommends no packages.

Versions of packages gnome-settings-daemon suggests:
ii  gnome-screensaver   2.28.0-2             GNOME screen saver and locker
ii  kde-window-manager  4:4.3.4-3            the KDE 4 window manager (KWin)
ii  metacity [x-window- 1:2.28.0-3           lightweight GTK+ window manager
ii  mutter [x-window-ma 2.28.1~git20091208-1 lightweight GTK+ window manager
ii  openbox [x-window-m 3.4.9-2              standards compliant, fast, light-w
ii  twm [x-window-manag 1:1.0.4-2            Tab window manager
ii  x11-xserver-utils   7.5+1                X server utilities

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gsd_apply-xrandr.patch
Type: text/x-diff
Size: 976 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20100108/ba444010/attachment.patch>