Bug#601295: libesd0: audsp systematically crashes

[Samuel Thibault]

Package: libesd0
Version: 0.2.41-7+youpi.1
Severity: important
Tags: patch

Hello,

audsp from festival systematically crashes, making it unusable. Valgrind
provides the following:

==25371== Conditional jump or move depends on uninitialised value(s)
==25371==    at 0x4C240B0: free (vg_replace_malloc.c:366)
==25371==    by 0x57C4F60: esd_free_all_info (esdmgr.c:267)
==25371==    by 0x57C536A: esd_get_all_info (esdmgr.c:154)
==25371==    by 0x51FD916: play_esd_wave(EST_Wave&, EST_Option&) (esd.cc:179)
==25371==    by 0x52A1522: play_wave(EST_Wave&, EST_Option&) (gen_audio.cc:120)
==25371==    by 0x403343: check_new_output() (audsp.cc:471)
==25371==    by 0x403A8C: auspl_main(int, char**) (audsp.cc:225)
==25371==    by 0x403EF8: main (audsp.cc:194)
==25371==  Uninitialised value was created by a heap allocation
==25371==    at 0x4C244E8: malloc (vg_replace_malloc.c:236)
==25371==    by 0x57C5135: esd_get_all_info (esdmgr.c:130)
==25371==    by 0x51FD916: play_esd_wave(EST_Wave&, EST_Option&) (esd.cc:179)
==25371==    by 0x52A1522: play_wave(EST_Wave&, EST_Option&) (gen_audio.cc:120)
==25371==    by 0x403343: check_new_output() (audsp.cc:471)
==25371==    by 0x403A8C: auspl_main(int, char**) (audsp.cc:225)
==25371==    by 0x403EF8: main (audsp.cc:194)

The server field is indeed not initialized to NULL, here is a patch to
do so.

Samuel

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.36 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages libesd0 depends on:
ii  esound-common          0.2.41-7+youpi.1  Enlightened Sound Daemon - Common 
ii  libasound2             1.0.21a-1+youpi.1 shared library for ALSA applicatio
ii  libaudiofile0          0.2.6-8           Open-source version of SGI's audio
ii  libc6                  2.11.2-6          Embedded GNU C Library: Shared lib

libesd0 recommends no packages.

Versions of packages libesd0 suggests:
pn  esound                        <none>     (no description available)
ii  esound-clients                0.2.41-7   Enlightened Sound Daemon - clients

-- no debconf information

-- 
Samuel Thibault <samuel.thibault at fnac.net>
Tu as lu les docs. Tu es devenu un informaticien. Que tu le veuilles
ou non. Lire la doc, c'est le Premier et Unique Commandement de
l'informaticien.
-+- TP in: Guide du Linuxien pervers - "L'�vangile selon St Thomas"
-------------- next part --------------
--- ./esdmgr.c.original	2010-10-25 00:35:28.000000000 +0200
+++ ./esdmgr.c	2010-10-25 00:35:31.000000000 +0200
@@ -128,6 +128,7 @@
 
     /* allocate the entire info structure, and set defaults to NULL */
     esd_info_t *info = (esd_info_t *) malloc( sizeof(esd_info_t) );
+    info->server = NULL;
     info->player_list = NULL;
     info->sample_list = NULL;