Bug#642496: quadrapassel doesn't move the top line down when removing lines

Matthew Wilcox matthew at wil.cx
Fri Sep 23 02:37:58 UTC 2011

Package: gnome-games
Version: 2.30.2-2
Tags: patch

If you fill the entire playing field with blocks, then remove some lines
by completing a row, the top line stays stationary.  It turns out to be
a simple fencepost error as the below patch (which fixes the problem)

The easiest way to reproduce the problem is fill the entire left or
right column with blocks, right up to the top, then clear the bottom row.

What happens is this:


when it should look like this:


diff -urp gnome-games-2.30.2/quadrapassel/blockops.cpp gnome-games-qpfix/quadrapassel/blockops.cpp
--- gnome-games-2.30.2/quadrapassel/blockops.cpp	2010-04-10 01:01:17.000000000 -0400
+++ gnome-games-qpfix/quadrapassel/blockops.cpp	2011-09-22 15:17:47.000000000 -0400
@@ -363,7 +363,7 @@ BlockOps::checkFullLines()
 	clutter_behaviour_remove_all (explode_fade_behaviour);
 	clutter_behaviour_remove_all (explode_scale_behaviour);
-	for (int y = MIN (posy + 4, LINES); y > 0; --y)
+	for (int y = MIN (posy + 4, LINES); y >= 0; --y)
 		if (checkFullLine (y))

Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

More information about the pkg-gnome-maintainers mailing list