Bug#643351: anjuta: FTBFS: am-project.c:1600:7: error: format not a string literal and no format arguments [-Werror=format-security]

[Didier Raboud]

Source: anjuta
Version: 2:3.0.3.0-3
Severity: serious
Tags: wheezy sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20110923 qa-ftbfs hardening-format-security hardening
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
> /bin/bash ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../..  -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare    -pthread -DGSEAL_ENABLE -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-3.0 -I/usr/include/cairo -I/usr/include/gio-unix-2.0/   -DGSEAL_ENABLE -pthread -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/libgdl-3.0 -I/usr/include/gtk-3.0 -I/usr/include/libxml2 -I/usr/include/cairo -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include    -I../.. -I../../libanjuta -DPACKAGE_PIXMAPS_DIR=\""/usr/share/pixmaps/anjuta"\" -DPACKAGE_LIB_DIR=\""/usr/lib/anjuta"\" -DPACKAGE_DATA_DIR=\""/usr/share/anjuta"\" -DG_LOG_DOMAIN=\"am-project\"  -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare  -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall -c -o am-project.lo am-project.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -pthread -DGSEAL_ENABLE -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-3.0 -I/usr/include/cairo -I/usr/include/gio-unix-2.0/ -DGSEAL_ENABLE -pthread -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/libgdl-3.0 -I/usr/include/gtk-3.0 -I/usr/include/libxml2 -I/usr/include/cairo -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I../.. -I../../libanjuta -DPACKAGE_PIXMAPS_DIR=\"/usr/share/pixmaps/anjuta\" -DPACKAGE_LIB_DIR=\"/usr/lib/anjuta\" -DPACKAGE_DATA_DIR=\"/usr/share/anjuta\" -DG_LOG_DOMAIN=\"am-project\" -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall -c am-project.c  -fPIC -DPIC -o .libs/am-project.o
> am-project.c: In function 'amp_project_load_root':
> am-project.c:1600:7: error: format not a string literal and no format arguments [-Werror=format-security]
> am-project.c: At top level:
> am-project.c:408:1: warning: 'ac_init_default_tarname' defined but not used [-Wunused-function]
> cc1: some warnings being treated as errors
> 
> make[5]: *** [am-project.lo] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2011/09/23/anjuta_2:3.0.3.0-3_lsid64.buildlog

This happened because since dpkg 1.16.0 [0], hardening flags are enabled 
under various conditions.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.